Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Deprecate MD5 APIs; document remaining usage #2964

Merged
merged 1 commit into from
Aug 24, 2020
Merged

chore: Deprecate MD5 APIs; document remaining usage #2964

merged 1 commit into from
Aug 24, 2020

Conversation

palpatim
Copy link
Member

@palpatim palpatim commented Aug 21, 2020 •
edited
Loading

Description of changes:

aws_md5String

  • This PR: Deprecate the publicly exported method, to provide customers with time to migrate to some other mechanism for calculating hashes before we remove it on or about 1-Dec-2020.
  • ECD 1-Dec-2020: Remove the publicly exported symbol and method implementation from the SDK altogether.

aws_md5StringLittleEndian

  • This PR: Deprecate the publicly exported method, to provide customers with time to migrate to some other mechanism for calculating hashes before we remove it on or about 1-Dec-2020.
  • Create a private implementation in Kinesis that mirrors the previous usage for naming local KinesisFirehose & Kinesis SQLite databases. Document the method implementation source code with an explanation that the usage does not represent a security issue.
  • ECD 1-Dec-2020: Remove the publicly exported symbol and method implementation from the SDK altogether.

aws_base64md5FromData

  • This PR: Document its usage in source code with an explanation that the usage does not represent a security issue.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@palpatim palpatim added core Issues related to AWSCore Pull Request labels Aug 21, 2020
@palpatim palpatim merged commit 5422154 into develop Aug 24, 2020
@palpatim palpatim deleted the palpatim/deprecate-md5 branch August 24, 2020 22:05
@palpatim palpatim mentioned this pull request Dec 23, 2020
Closed
gabek pushed a commit to KeepSafe/aws-sdk-ios that referenced this pull request Aug 31, 2023
@palpatim @gabek
chore: Deprecate MD5 APIs; document remaining usage (aws-amplify#2964)
eb51765
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@drochetti drochetti drochetti approved these changes

Assignees
No one assigned
Labels
core Issues related to AWSCore
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@palpatim @drochetti