fix: consider timestamp format for JSON protocol serialization #3182
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The JSON protocol (Rest-JSON, JSON 1.1) serialization ignores the timestampFormat trait of timestamp shapes in c2j model which causes it to default to unixTimetsamp format instead of the prescribed format. These changes add support for timestampFormat trait for JSON protocols. It also abstracts out the handling of timestamp shape serialization for different serialization protocols as they tend to share similar implementations. Added tests around these changes for various protocols.
phani-srikar
approved these changes
Oct 30, 2020
There was a problem hiding this comment.
Most of these changes are already reviewed in the staging repo. A fix was applied on top of those changes for deserialization in RestJSON protocol. These changes are tested for RestJSON serialization/deserialization through a sample app. Other protocols were only unit tested.
gabek
pushed a commit
to KeepSafe/aws-sdk-ios
that referenced
this pull request
Aug 31, 2023
…mplify#3182) The JSON protocol (Rest-JSON, JSON 1.1) serialization ignores the timestampFormat trait of timestamp shapes in c2j model which causes it to default to unixTimetsamp format instead of the prescribed format. These changes add support for timestampFormat trait for JSON protocols. It also abstracts out the handling of timestamp shape serialization for different serialization protocols as they tend to share similar implementations. Added tests around these changes for various protocols.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
The JSON protocol (Rest-JSON, JSON 1.1) serialization ignores the timestampFormat trait of timestamp shapes in c2j model which causes it to default to unixTimetsamp format instead of the prescribed format.
Description of changes:
These changes add support for timestampFormat trait for JSON protocols. It also abstracts out the handling of timestamp shape serialization for different serialization protocols as they tend to share similar implementations.
Added tests around these changes for various protocols.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.