Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(S3): rewrite create partial file function (#2314) #3786

Merged
merged 2 commits into from
Sep 23, 2021
Merged

Conversation

brennanMKE
Copy link
Contributor

@brennanMKE brennanMKE commented Sep 23, 2021

Issue #, if available:

#2314

Description of changes:

  • method has experienced crashes and uses low level POSIX API
  • uses higher level FileManager API with error checking
  • includes unit test for new implementation

Check points:

  • Added new tests to cover change, if needed
  • All unit tests pass
  • All integration tests pass
  • Updated CHANGELOG.md
  • Documentation update for the change if required
  • PR title conforms to conventional commit style

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Brennan Stehling and others added 2 commits September 22, 2021 17:12
* method has experienced crashes and uses low level POSIX API
* uses higher level FileManager API with error checking
* includes unit test for new implementation
@brennanMKE brennanMKE merged commit 86436cd into main Sep 23, 2021
@brennanMKE brennanMKE deleted the stehlib.2314 branch September 23, 2021 21:36
gabek pushed a commit to KeepSafe/aws-sdk-ios that referenced this pull request Aug 31, 2023
…-amplify#3786)

* fix(S3): rewrite create partial file function (aws-amplify#2314)

* method has experienced crashes and uses low level POSIX API
* now uses higher level FileManager API with error checking
* includes unit test for new implementation
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants