Add Getting Started for Next.js & Server-Side Rendering docs #2381
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ericclemmons
changed the title
yarn test wasn't working locally and hung after pre-rendering
|
Been following this and the discussion post. Just wanted to say awesome work! This is super exciting! |
dabit3
reviewed
Sep 11, 2020
dabit3
reviewed
Sep 11, 2020
|
On the "Getting started with SSR" page, after the first paragraph, would it be beneficial to add a paragraph/diagram/link explaining why building for SSR is different than client-side only--or specifically why Amplify behaves differently. That way those migrating from CRA -> NextJS for the first time have some context on why things are done differently. |
sammartinez
reviewed
Sep 14, 2020
dabit3
reviewed
Sep 14, 2020
ericclemmons
added a commit
that referenced
this pull request
Sep 30, 2020
Regression from #2381 where the React fragment was intended to be shared for both React & Next.js
sammartinez
pushed a commit
that referenced
this pull request
Sep 30, 2020
Regression from #2381 where the React fragment was intended to be shared for both React & Next.js
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
aws-amplify/amplify-js#5435
Description of changes:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.