Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

automate snapshot testing #2561

Closed
PatMyron opened this issue Jan 19, 2023 · 0 comments · Fixed by #2566
Closed

automate snapshot testing #2561

PatMyron opened this issue Jan 19, 2023 · 0 comments · Fixed by #2566

Comments

@PatMyron
Copy link
Contributor

PatMyron commented Jan 19, 2023 •
edited
Loading

largest files in this repo that are still hand-touched (~15K lines / ~600MB):
https://github.com/aws-cloudformation/cfn-lint/tree/main/test/fixtures/results

documented command/script should generate all these results, so you only have to review automated changes
#903

Also fine for the snapshot format itself to change if it makes this easier, format itself won't matter as much anymore once it's not hand-written. currently --format json, easily automatable

Could even completely automate snapshot generation once we have a documented command/script: aws/aws-cdk#23759
PatMyron added a commit to PatMyron/cfn-python-lint that referenced this issue Jan 25, 2023
@PatMyron
script to generate test snapshots
602c957 
close aws-cloudformation#2561
@PatMyron PatMyron mentioned this issue Jan 25, 2023
Merged
PatMyron added a commit to PatMyron/cfn-python-lint that referenced this issue Jan 25, 2023
@PatMyron
script to generate test snapshots
d64c30f 
close aws-cloudformation#2561
kddejong added a commit that referenced this issue Jan 26, 2023
@PatMyron @kddejong
script to generate test snapshots (#2566)
ea842b8 
* script to generate test snapshots

close #2561

* inline directory name

Co-authored-by: Kevin DeJong <kddejong@amazon.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

script to generate test snapshots PatMyron/cfn-python-lint
1 participant
@PatMyron