Parse pricing API to get allowed values #586
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #586 +/- ##
==========================================
+ Coverage 84.82% 84.89% +0.06%
==========================================
Files 113 113
Lines 6439 6453 +14
Branches 1504 1505 +1
==========================================
+ Hits 5462 5478 +16
+ Misses 629 627 -2
Partials 348 348
Continue to review full report at Codecov.
|
fatbasstard
force-pushed
the
api
branch
4 times, most recently
from
ed01690
to
1527899
Compare
Closed
Maybe rebuild into something "smarter"
|
Meh, messed up GitHub.. Damn |
Instead of using a hardcoded region, all rules fetch the data from the Template now (which is defaulted to `us-east-1`). In short term this means that if 1 region is specified in the linter, it actually uses that region
Add Redshift instance types and added logging to the script
fatbasstard
changed the title
|
Sorry for the delay in reviewing this. I haven't had the time to go heads down on the initialize changes. There are a few scenarios related to that I want to run through and make sure we have them covered. |
kddejong
approved these changes
Jan 25, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Took over the commit from @kddejong to make changes and improve the allowedValues rule using this: The first "region specific" allowedValues 🎉
Current status/changes:
us-east-1, the first region is used (by default that's us-east-1) so the specified region is actually used.By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.