Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert README to Markdown #393

Merged
merged 2 commits into from
Feb 13, 2020
Merged

Convert README to Markdown #393

merged 2 commits into from
Feb 13, 2020

Conversation

tobywf
Copy link
Contributor

@tobywf tobywf commented Feb 13, 2020

Issue #, if available:

Description of changes: The reStructuredText seems to fail to render, I think the issue is the backticks around some inline code.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@tobywf tobywf self-assigned this Feb 13, 2020
Copy link
Contributor

@johnttompkins johnttompkins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Going to test branch to make sure it uploads

@johnttompkins
Copy link
Contributor

Still doesn't upload. May need to dive a bit deeper and see what pypi uses to render

@tobywf
Copy link
Contributor Author

tobywf commented Feb 13, 2020

i'll just proceed with converting it to markdown

@tobywf tobywf changed the title Fix reST README (backticks issue) Convert README to Markdown Feb 13, 2020
@johnttompkins
Copy link
Contributor

twine check dist/cloudformation_cli-0.1.2-py3-none-any.whl 
Checking dist/cloudformation_cli-0.1.2-py3-none-any.whl: PASSED

@johnttompkins johnttompkins merged commit 19c1570 into aws-cloudformation:master Feb 13, 2020
@tobywf tobywf deleted the fix-rst branch February 13, 2020 23:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants