[BugFix]: Fix panic occurring for regex with incomplete groupings #429
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joshfried-aws
requested review from
indraneelray,
setttings,
brianchou121,
razcloud,
Brianwithay21,
wkexiang,
frankret,
reza-aws,
rpdutt,
minhphuong98 and
Neel-Renavikar
and removed request for
indraneelray
rpdutt
approved these changes
Dec 6, 2023
setttings
approved these changes
Dec 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
N/A
Description of changes:
After running the guard fuzzer we found an issue where Fancy regex does not handle the case where an improper grouping is present in the regex. To fix this we added a check before trying to create the regex, checking if unescaped parenthesis are matched. If they are not matched, we error out.
I have also added tests to ensure the fix is correct.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license