[Misc]: Reverting previous changes + bumping up fancy-regex version #442
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ous commit since they now handle the previously failing case
joshfried-aws
requested review from
akshayrane,
setttings,
Neel-Renavikar,
razcloud,
Brianwithay21,
wkexiang,
frankret,
brianlaoaws,
reza-aws,
rpdutt and
minhphuong98
rpdutt
approved these changes
Jan 4, 2024
setttings
approved these changes
Jan 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
N/A
Description of changes:
In #429 we made a change that handled unmatched groupings, and in #428 we made changes to check for control characters in a regex. The maintainers of fancy-regex addressed this here: fancy-regex/fancy-regex#125
This PR bumps up our dependency to use fancy-regex 0.13.0 and removes the code changes we made to guard against these edge cases.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license