Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

automatically generate desired controller-gen binary #651

Merged
merged 1 commit into from
Jan 20, 2021

Conversation

prashao
Copy link
Contributor

@prashao prashao commented Jan 18, 2021

Issue #, if available:
#633

Description of changes:

  1. Desired version of controller-gen binary will be automatically generated with 'make build-controller SERVICE=$SERVICE' command
  2. Removed kubernetes-sigs/controller-tools from prerequisites as users might try to install controller-gen manually and run into errors mentioned in [Documentation] Dev-docs is not clear about how to install correct controller-gen binary #633 . The Makefile change will anyways install the correct version automatically or indicate the user to install the correct one in case of mismatch as below -

$make build-controller SERVICE=$SERVICE
building ack-generate ... ok.
FATAL: Existing version of controller-gen Version: v0.4.1, required version is v0.4.0.
FATAL: Please uninstall controller-gen and install the required version with scripts/install-controller-gen.sh.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Copy link
Collaborator

@jaypipes jaypipes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @prashao. I wonder if some of the other pre-requisites mentioned in the testing docs (like kind and jq) should have similar PRs...

@jaypipes jaypipes merged commit 3742d4a into aws-controllers-k8s:main Jan 20, 2021
@prashao prashao deleted the dev-docs-testing branch January 20, 2021 22:34
@prashao
Copy link
Contributor Author

prashao commented Jan 20, 2021

kind & jq have pretty neat installation instructions so we should be good there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants