Configure klog to use the ACK runtime logger
#126
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This patch addresses an issue where the leaderElection feature was using `klog/v2` behind the scenes, which was set using a different logger than the one we use in ACK. This inconsitancy caused the controller to have two different log styles. Fortunetly `klog/v2` allow users to set their own loggers, and more fortunetely `go-logr` is compatible with both `klog` and `zap` the logger we use in ACK runtime. Setting `klog` logger results in a more consistant and smooth logging experience. Signed-off-by: Amine <hilalyamine@gmail.com>
a-hilaly
changed the title
klog logger using the ACK runtime loggerklog to use the ACK runtime logger
acornett21
approved these changes
Sep 21, 2023
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: a-hilaly, acornett21, jljaco The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch addresses an issue where the leaderElection feature was using
klog/v2behind the scenes, which was set using a different logger thanthe one we use in ACK. This inconsitancy caused the controller to have
two different log styles.
Fortunetly
klog/v2allow users to set their own loggers, and morefortunetely
go-logris compatible with bothklogandzapthelogger we use in ACK runtime.
Setting
kloglogger results in a more consistant and smooth loggingexperience.
Signed-off-by: Amine Hilaly hilalyamine@gmail.com
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.