Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: fix external PR #1423

Merged
merged 2 commits into from
Mar 17, 2023
Merged

ci: fix external PR #1423

merged 2 commits into from
Mar 17, 2023

Conversation

MikeDombo
Copy link
Contributor

@MikeDombo MikeDombo commented Mar 17, 2023

Issue #, if available:

Description of changes:

Our integ/unit test comments just stopped working. This PR fixes the workflow to comment again.

Why is this change necessary:

How was this change tested:

  • Updated or added new unit tests.
  • Updated or added new integration tests.
  • Updated or added new end-to-end tests.
  • If my code makes a remote network call, it was tested with a proxy.

Any additional information or context required to review the change:

Documentation Checklist:

  • Updated the README if applicable.

Compatibility Checklist:

  • I confirm that the change is backwards compatible.
  • Any modification or deletion of public interfaces does not impact other plugin components.
  • For external library version updates, I have reviewed its change logs and Nucleus does not consume
    any deprecated method or type.

Refer to Compatibility Guidelines for more information.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@MikeDombo MikeDombo marked this pull request as ready for review March 17, 2023 00:41
@MikeDombo MikeDombo merged commit 3636b0e into main Mar 17, 2023
@MikeDombo MikeDombo deleted the MikeDombo-patch-1 branch March 17, 2023 01:30
yitingb pushed a commit that referenced this pull request Mar 23, 2023
MikeDombo added a commit that referenced this pull request Mar 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants