fix: Enable EventBridge rules/targets before EKS cluster (#1728)

aws-ia · Aug 14, 2023 · 145e6e2 · 145e6e2
1 parent 711525c
commit 145e6e2
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 2 deletions.
diff --git a/.github/scripts/plan-examples.py b/.github/scripts/plan-examples.py
@@ -10,6 +10,7 @@ def get_examples():
     """
     exclude = {
         'examples/appmesh-mtls',  # excluded until Rout53 is setup
+        'examples/privatelink-access',
         'examples/blue-green-upgrade/environment',
         'examples/blue-green-upgrade/modules/eks_cluster'
     }

diff --git a/examples/privatelink-access/README.md b/examples/privatelink-access/README.md
@@ -21,7 +21,7 @@ created so that it can respond to the ENIs created by the EKS control plane:
 
 ```sh
 terraform init
-terraform apply -target=module.create_eni_lambda -target=module.nlb
+terraform apply -target=module.eventbridge -target=module.nlb
 ```
 
 Enter `yes` at command prompt to apply

diff --git a/examples/privatelink-access/privatelink.tf b/examples/privatelink-access/privatelink.tf
@@ -218,7 +218,9 @@ module "delete_eni_lambda" {
 
   environment_variables = {
     TARGET_GROUP_ARN = module.nlb.target_group_arns[0]
-    EKS_CLUSTER_NAME = module.eks.cluster_name
+
+    # Passing local.name in lieu of module.eks.cluster_name to avoid dependency
+    EKS_CLUSTER_NAME = local.name
   }
 
   allowed_triggers = {