Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE] Add-ons to provide IAM role arn and name as outputs and IAM roles have easy to find prefix #816

Closed
andrewhibbert opened this issue Jul 29, 2022 · 10 comments
Assignees
Labels
enhancement New feature or request

Comments

@andrewhibbert
Copy link

Is your feature request related to a problem? Please describe

Would be good if each add on provides the details for the IRSA IAM role as outputs as it is difficult to find the roles as they are terraform-<uid>, perhaps a prefix would be good also so it is searchable in the UI

Describe the solution you'd like

As above

Describe alternatives you've considered

N/A

Additional context

N/A

@andrewhibbert andrewhibbert changed the title [FEATURE] Add-ons to provide IAM role arn and name as outputs [FEATURE] Add-ons to provide IAM role arn and name as outputs and IAM roles have easy to find prefix Jul 29, 2022
@bryantbiggs bryantbiggs added enhancement New feature or request addon labels Aug 4, 2022
@bryantbiggs
Copy link
Contributor

@bryantbiggs bryantbiggs moved this from Backlog to Done in Old EKS Blueprints (Archived) Aug 23, 2022
@andrewhibbert
Copy link
Author

It also needs to be in the outputs for the other modules though doesn't it - https://github.com/aws-ia/terraform-aws-eks-blueprints/blob/main/modules/kubernetes-addons/outputs.tf

@bryantbiggs
Copy link
Contributor

bryantbiggs commented Aug 23, 2022

apologies - this was not clear in the ticket with the lack of detail provided

@andrewhibbert
Copy link
Author

There were several problems reported too:

@bryantbiggs
Copy link
Contributor

There were several problems reported too:

Where were these reported?

@andrewhibbert
Copy link
Author

Here - #816 (comment).

I was finding it difficult to find the IAM roles before as they were terraform-

@bryantbiggs
Copy link
Contributor

you have roles named terraform-* today?

@bryantbiggs bryantbiggs reopened this Aug 23, 2022
@andrewhibbert
Copy link
Author

Not with the latest versions as I've said here it is improved - #816 (comment). You cannot override the role name though via the addons

@florentio
Copy link
Contributor

Hello @andrewhibbert this PR #908 is supposed to let consumers override the role name of IRSA though via the addons once it is merged.

@bryantbiggs
Copy link
Contributor

closed in #1136

@bryantbiggs bryantbiggs moved this from Working on it to Done in Old EKS Blueprints (Archived) Nov 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
No open projects
Development

No branches or pull requests

3 participants