New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
IRSA module refactor (No Breaking changes) #832
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great!
Co-authored-by: Bryant Biggs <bryantbiggs@gmail.com>
|
@@ -1,3 +1,7 @@ | |||
locals { | |||
eks_oidc_issuer_url = "${replace(var.eks_oidc_provider_arn, "/^(.*provider/)/", "")}:sub" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@vara-bonthu should this have :sub
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is breaking things, I believe. Look at #837
Co-authored-by: Bryant Biggs <bryantbiggs@gmail.com>
What does this PR do?
This PR is raised to simplify the IRSA module variables. No breaking changes are introduced by this PR to EKS blueprints.
However, users who are calling IRSA module directly needs a simple change to your code. Check the AFTER code snippet. FAQ.md also provides these details
Before
This is the current usage of consuming IRSA module directly.
After
Related Issues
closes #697
closes #814
Motivation
More
pre-commit run -a
with this PRNote: Not all the PRs required examples and docs except a new pattern or add-on added.
For Moderators
Additional Notes