Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Helm-addon irsa_config default value for create_namespace condition #1019

Merged

Conversation

sebolabs
Copy link
Contributor

@sebolabs sebolabs commented Oct 3, 2022

What does this PR do?

With 4.12 the default value of the irsa_config variable was changed from null to {} while the value of the create_namespace property within the resource "helm_release" "addon" was not updated and remained as:

var.irsa_config != null ? false : try(var.helm_config["create_namespace"], false)

The correct value should be:

var.irsa_config != {} ? false : try(var.helm_config["create_namespace"], false)

Versions comparison: v4.11.0...v4.12.0#diff-08ec4987c7b396bd22851dba98a35f66754059cbc09e6f88a0801533f8d03946R33

Motivation

I was using v4.11.0, updated to v4.12.0, and spotted that the create_namespace value I wasn't overriding was suddenly changed from the default true to false.

More

  • Yes, I have tested the PR using my local account setup (Provide any test evidence report under Additional Notes)
  • Yes, I have added a new example under examples to support my PR
  • Yes, I have created another PR for add-ons under add-ons repo (if applicable)
  • Yes, I have updated the docs for this feature
  • Yes, I ran pre-commit run -a with this PR

Note: Not all the PRs require a new example and/or doc page. In general:

  • Use an existing example when possible to demonstrate a new addons usage
  • A new docs page under docs/add-ons/* is required for new a new addon

For Moderators

  • E2E Test successfully complete before merge?

Additional Notes

Got:

No changes. Your infrastructure matches the configuration.

Terraform has compared your real infrastructure against your configuration and found no differences, so no changes are needed.

Instead of:

Terraform will perform the following actions:

  # module.eks_addons.module.argocd[0].module.helm_addon.helm_release.addon[0] will be updated in-place
  ~ resource "helm_release" "addon" {
      ~ create_namespace           = true -> false
        id                         = "argo-cd"
        name                       = "argo-cd"
        # (28 unchanged attributes hidden)

        # (1 unchanged block hidden)
    }

Plan: 0 to add, 1 to change, 0 to destroy.

@sebolabs sebolabs changed the title fix: helm-addon irsa_config default value for create_namespace condition fix: Helm-addon irsa_config default value for create_namespace condition Oct 3, 2022
@bryantbiggs bryantbiggs temporarily deployed to EKS Blueprints Test October 4, 2022 11:54 Inactive
@bryantbiggs bryantbiggs temporarily deployed to EKS Blueprints Test October 4, 2022 11:55 Inactive
@bryantbiggs bryantbiggs merged commit 7ee138d into aws-ia:main Oct 4, 2022
allamand pushed a commit to allamand/terraform-aws-eks-blueprints that referenced this pull request Dec 15, 2022
…ion (aws-ia#1019)

Co-authored-by: Bryant Biggs <bryantbiggs@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants