feat: Add support for EKS addon data version selection of most_recent (true/false)
#1048
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t` (`true`/`false`)
bryantbiggs
requested review from
askulkarni2,
kcoleman731,
vara-bonthu and
Zvikan
as code owners
bryantbiggs
commented
Oct 11, 2022
| @@ -33,6 +31,8 @@ repos: | |||
| - '--args=--only=terraform_required_providers' | |||
| - '--args=--only=terraform_standard_module_structure' | |||
| - '--args=--only=terraform_workspace_remote' | |||
| - id: terraform_validate | |||
There was a problem hiding this comment.
just moved lower in the checks since it takes the longest - the shortest checks will return first before the longer checks
bryantbiggs
commented
Oct 11, 2022
| module "eks_blueprints_kubernetes_addons" { | ||
| # Essential inputs are not shown for brevity | ||
|
|
||
| enable_amazon_eks_coredns = true | ||
| amazon_eks_coredns_config = { | ||
| addon_version = data.aws_eks_addon_version.default["coredns"].version | ||
| resolve_conflicts = "OVERWRITE" |
There was a problem hiding this comment.
removing defaults and showing whats unique
allamand
pushed a commit
to allamand/terraform-aws-eks-blueprints
that referenced
this pull request
Dec 15, 2022
…t` (`true`/`false`) (aws-ia#1048)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
most_recent(true/false)resolve_conflictsas"OVERWRITE"as the defaultMotivation
More
pre-commit run -awith this PRNote: Not all the PRs require a new example and/or doc page. In general:
docs/add-ons/*is required for new a new addonFor Moderators
Additional Notes