Kubernetes-addon namespaces can be specified and creation optional #595

bobdoah · 2022-06-03T19:29:21Z

What does this PR do?

This change makes it possible to use any of the kubernetes-addon modules with an already extant namespace. In a number of instances, the namespace creation is done via the IRSA module. In those cases, this PR also ensures the namespace is passed from the helm_config.

Motivation

I'm attempting to get my colleagues to adopt this module into our EKS Terraform projects. In our case we deploy operational modules to a single namespace. This is created outside the addon modules. To migrate to these modules, we need to be able to disable namespace creation and allow the namespace to be specified.

More

Yes, I have tested the PR using my local account setup (Provide any test evidence report under Additional Notes)
Yes, I have added a new example under examples to support my PR
Yes, I have updated the docs for this feature
Yes, I ran pre-commit run -a with this PR

Note: Not all the PRs required examples and docs except a new pattern or add-on added.

For Moderators

E2E Test successfully complete before merge?

Additional Notes

modules/kubernetes-addons/adot-collector-haproxy/main.tf

Hokwang · 2022-06-08T15:37:27Z

Please add kubernetes-dashboard

bobdoah · 2022-06-09T08:59:34Z

Please add kubernetes-dashboard

Done @Hokwang. I thought the namespace had been removed entirely from the Terraform. Thanks for highlighting this.

bobdoah · 2022-06-14T12:17:40Z

@bryantbiggs any chance you could review this again?

modules/kubernetes-addons/aws-privateca-issuer/locals.tf

bobdoah · 2022-06-24T13:33:47Z

Thanks for the changes @bryantbiggs. Was just looking at your comments and then they appeared.

bryantbiggs · 2022-06-24T13:34:35Z

@bobdoah 😅 give me a sec and I should have the rest of the updates - we'll get this across the line today

bryantbiggs

Thanks for the PR @bobdoah !

vara-bonthu

@bobdoah Thanks for the PR but would expect that this PR should address only the namespace issue as mentioned the description.

This is a very big change with major refactoring for all the add-ons. It's advisable to do this kind of refactoring with small PRs for each add-on with proper testing.

vara-bonthu · 2022-06-25T10:45:32Z

modules/kubernetes-addons/agones/main.tf

 module "helm_addon" {
-  source            = "../helm-addon"
+  source = "../helm-addon"
+
  manage_via_gitops = var.manage_via_gitops
-  helm_config       = local.helm_config
-  irsa_config       = null
-  addon_context     = var.addon_context

-  depends_on = [kubernetes_namespace_v1.this]
-}
+  helm_config = merge(
+    {
+      name             = "agones"
+      chart            = "agones"
+      repository       = "https://agones.dev/chart/stable"
+      version          = "1.23.0"
+      namespace        = "agones-system"
+      create_namespace = true
+      description      = "Agones Gaming Server Helm Chart deployment configuration"
+      values           = [file("${path.module}/values.yaml")]
+    },
+    var.helm_config
+  )


@bobdoah Any reason why you are refactoring all the add-ons?

@vara-bonthu I made most of the changes. When reviewing the PR, there were too many inconsistencies across the different addons in how names, nampespaces, etc. + the merging of provided config with var.helm_config that I just dove in to start correcting. Please let me know how you would like to handle these changes so that the users can opt in or out of creating namespaces while keeping the addons consistent

askulkarni2

LGTM! pending CI checks.

bryantbiggs · 2022-06-30T21:59:16Z

@askulkarni2 should be ready to re-review if you have time - merge away if things look ok

askulkarni2

LGTM!

bobdoah · 2022-07-01T07:54:53Z

Thanks for all the changes to sort this @bryantbiggs and merging @askulkarni2

…on optional (aws-ia#595) Co-authored-by: Bryant Biggs <bryantbiggs@gmail.com>

bobdoah requested review from askulkarni2, kcoleman731, vara-bonthu, bryantbiggs and Zvikan as code owners June 3, 2022 19:29

bobdoah temporarily deployed to EKS Blueprints Test June 3, 2022 19:29 Inactive

bobdoah changed the title ~~Optional namespaces~~ Namespaces can be specified and creation optional Jun 3, 2022

bobdoah changed the title ~~Namespaces can be specified and creation optional~~ Kubernetes-addon namespaces can be specified and creation optional Jun 3, 2022

bobdoah had a problem deploying to EKS Blueprints Test June 5, 2022 14:27 Failure

bobdoah had a problem deploying to EKS Blueprints Test June 6, 2022 09:13 Failure

bryantbiggs reviewed Jun 6, 2022

View reviewed changes

modules/kubernetes-addons/adot-collector-haproxy/main.tf Outdated Show resolved Hide resolved

bobdoah force-pushed the optional-namespaces branch from 51da248 to 1691a05 Compare June 8, 2022 13:17

bobdoah had a problem deploying to EKS Blueprints Test June 8, 2022 13:17 Failure

bobdoah force-pushed the optional-namespaces branch from 1691a05 to fa86027 Compare June 8, 2022 13:21

bobdoah had a problem deploying to EKS Blueprints Test June 8, 2022 13:21 Failure

bobdoah requested a review from bryantbiggs June 8, 2022 13:59

bobdoah force-pushed the optional-namespaces branch from fa86027 to 6ff42ee Compare June 9, 2022 08:50

bobdoah had a problem deploying to EKS Blueprints Test June 9, 2022 08:50 Failure

bobdoah force-pushed the optional-namespaces branch from 6ff42ee to 4816040 Compare June 13, 2022 09:20

bobdoah had a problem deploying to EKS Blueprints Test June 13, 2022 09:20 Failure

bobdoah force-pushed the optional-namespaces branch from 4816040 to f6ce234 Compare June 14, 2022 12:17

bobdoah had a problem deploying to EKS Blueprints Test June 14, 2022 12:17 Failure

bobdoah force-pushed the optional-namespaces branch from f6ce234 to 3fd6e73 Compare June 15, 2022 13:22

bobdoah had a problem deploying to EKS Blueprints Test June 15, 2022 13:23 Failure

bobdoah force-pushed the optional-namespaces branch from 3fd6e73 to 0805d7e Compare June 17, 2022 12:54

bobdoah had a problem deploying to EKS Blueprints Test June 17, 2022 12:54 Failure

bobdoah had a problem deploying to EKS Blueprints Test June 20, 2022 10:38 Failure

bryantbiggs reviewed Jun 24, 2022

View reviewed changes

modules/kubernetes-addons/aws-privateca-issuer/locals.tf Show resolved Hide resolved

bryantbiggs had a problem deploying to EKS Blueprints Test June 24, 2022 13:29 Failure

bryantbiggs had a problem deploying to EKS Blueprints Test June 24, 2022 19:19 Failure

bryantbiggs had a problem deploying to EKS Blueprints Test June 24, 2022 19:20 Failure

bryantbiggs temporarily deployed to EKS Blueprints Test June 24, 2022 21:07 Inactive

bryantbiggs force-pushed the optional-namespaces branch from d626d8f to 04c6995 Compare June 24, 2022 21:52

bryantbiggs temporarily deployed to EKS Blueprints Test June 24, 2022 21:52 Inactive

bryantbiggs approved these changes Jun 24, 2022

View reviewed changes

vara-bonthu requested changes Jun 25, 2022

View reviewed changes

This was referenced Jun 29, 2022

[FEATURE] Make it possible to disable namespace creation for ArgoCD #704

Closed

[QUESTION] Custom namespace for argocd application? #663

Closed

bryantbiggs force-pushed the optional-namespaces branch from 04c6995 to 3f49a9e Compare June 29, 2022 19:09

bryantbiggs temporarily deployed to EKS Blueprints Test June 29, 2022 19:09 Inactive

vara-bonthu approved these changes Jun 29, 2022

View reviewed changes

Zvikan approved these changes Jun 29, 2022

View reviewed changes

kcoleman731 approved these changes Jun 29, 2022

View reviewed changes

askulkarni2 requested changes Jun 29, 2022

View reviewed changes

Merge branch 'main' into optional-namespaces

865d346

bryantbiggs temporarily deployed to EKS Blueprints Test June 30, 2022 20:16 Inactive

fix: Correct for CI checks

7fe5962

bryantbiggs temporarily deployed to EKS Blueprints Test June 30, 2022 21:54 Inactive

askulkarni2 approved these changes Jun 30, 2022

View reviewed changes

askulkarni2 merged commit 7c7b6ec into aws-ia:main Jun 30, 2022

bobdoah deleted the optional-namespaces branch July 13, 2022 09:37

bryantbiggs mentioned this pull request Jul 15, 2022

[FEATURE] Allow namespaces to be over-ridden in all addons (prometheus and others) #498

Closed

allamand pushed a commit to allamand/terraform-aws-eks-blueprints that referenced this pull request Dec 15, 2022

feat(addons): Kubernetes-addon namespaces can be specified and creati…

e4f9967

…on optional (aws-ia#595) Co-authored-by: Bryant Biggs <bryantbiggs@gmail.com>

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Kubernetes-addon namespaces can be specified and creation optional #595

Kubernetes-addon namespaces can be specified and creation optional #595

bobdoah commented Jun 3, 2022 •

edited

Hokwang commented Jun 8, 2022

bobdoah commented Jun 9, 2022

bobdoah commented Jun 14, 2022

bobdoah commented Jun 24, 2022

bryantbiggs commented Jun 24, 2022

bryantbiggs left a comment

vara-bonthu left a comment

vara-bonthu Jun 25, 2022

bryantbiggs Jun 25, 2022

askulkarni2 left a comment

bryantbiggs commented Jun 30, 2022

askulkarni2 left a comment

bobdoah commented Jul 1, 2022

Kubernetes-addon namespaces can be specified and creation optional #595

Kubernetes-addon namespaces can be specified and creation optional #595

Conversation

bobdoah commented Jun 3, 2022 • edited

What does this PR do?

Motivation

More

For Moderators

Additional Notes

Hokwang commented Jun 8, 2022

bobdoah commented Jun 9, 2022

bobdoah commented Jun 14, 2022

bobdoah commented Jun 24, 2022

bryantbiggs commented Jun 24, 2022

bryantbiggs left a comment

Choose a reason for hiding this comment

vara-bonthu left a comment

Choose a reason for hiding this comment

vara-bonthu Jun 25, 2022

Choose a reason for hiding this comment

bryantbiggs Jun 25, 2022

Choose a reason for hiding this comment

askulkarni2 left a comment

Choose a reason for hiding this comment

bryantbiggs commented Jun 30, 2022

askulkarni2 left a comment

Choose a reason for hiding this comment

bobdoah commented Jul 1, 2022

bobdoah commented Jun 3, 2022 •

edited