feat(cluster-autoscaler): allow user to upgrade cluster-autoscaler #715
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chubchubsancho
requested review from
askulkarni2,
kcoleman731,
vara-bonthu,
bryantbiggs and
Zvikan
as code owners
vara-bonthu
approved these changes
Jun 30, 2022
There was a problem hiding this comment.
Thanks for the fix @chubchubsancho . I agree with this approach 👍🏼
vara-bonthu
requested changes
Jun 30, 2022
| @@ -19,6 +19,7 @@ module "helm_addon" { | |||
| values = [templatefile("${path.module}/values.yaml", { | |||
| aws_region = var.addon_context.aws_region_name, | |||
| eks_cluster_id = var.addon_context.eks_cluster_id | |||
There was a problem hiding this comment.
Just noticed. You are missing a , at end of this line.
There was a problem hiding this comment.
nice catch i fix this
There was a problem hiding this comment.
I dont think you need a , in values template but the line number 20 has got one. That can be removed instead
There was a problem hiding this comment.
you're right , is not needed here just removed it
chubchubsancho
force-pushed
the
feat/cluster-autoscaler/ability-to-specify-image-tag
branch
from
a9c9119
to
e3e840f
Compare
Previously `image.tag` was set through `set_values` Due to this we were unable to upgrade cluster-autoscaler * redifine cluster-autoscaler image.tag on `values.yaml` * remove `set_values`
chubchubsancho
force-pushed
the
feat/cluster-autoscaler/ability-to-specify-image-tag
branch
from
e3e840f
to
3855efe
Compare
chubchubsancho
deleted the
feat/cluster-autoscaler/ability-to-specify-image-tag
branch
allamand
pushed a commit
to allamand/terraform-aws-eks-blueprints
that referenced
this pull request
Dec 15, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously
image.tagwas set throughset_valuesDue to this we were unable to upgrade cluster-autoscaler
values.yamlset_valuesWhat does this PR do?
Define default value for
cluster-autoscalerbased on cluster version and let user override this valueMotivation
Resolv #714
More
pre-commit run -awith this PRNote: Not all the PRs required examples and docs except a new pattern or add-on added.
For Moderators
Additional Notes