feat(argocd): add insecure parameter for argocd apps #721
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Added the optional insecure parameter for argocd apps. If you do not set the insecure parameter it will set to false by default. This does not break existing configurations.
Motivation
When using private repositories in private networks you often do not want to manage the public server certificates in addition to the private ones. The risk is very low that a man-in-the-middle attack is performed. Therefore I added the
insecure
parameter which can be set when creating an Argo app.Argo Docs on the insecure flag: https://argo-cd.readthedocs.io/en/stable/user-guide/private-repositories/#self-signed-untrusted-tls-certificates
This parameter resolves repo server errors like
error testing repository connectivity: ssh: handshake failed
.More
[ ] Yes, I have added a new example under examples to support my PR[ ] Yes, I have created another PR for add-ons under add-ons repo (if applicable)pre-commit run -a
with this PRNote: Not all the PRs required examples and docs except a new pattern or add-on added.
For Moderators
Additional Notes
Test report:
My config:
ArgoCD Repo Server Logs: