Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: unique NTH event rules names per cluster id #744

Merged
merged 2 commits into from
Jul 8, 2022
Merged

fix: unique NTH event rules names per cluster id #744

merged 2 commits into from
Jul 8, 2022

Conversation

Zvikan
Copy link
Contributor

@Zvikan Zvikan commented Jul 7, 2022

What does this PR do?

  • Adjust NTH event rules names to be unique using cluster id and ensuring string is limited to 64 chars per docs

Motivation

More

  • Yes, I have tested the PR using my local account setup (Provide any test evidence report under Additional Notes)
  • Yes, I have added a new example under examples to support my PR
  • Yes, I have created another PR for add-ons under add-ons repo (if applicable)
  • Yes, I have updated the docs for this feature
  • Yes, I ran pre-commit run -a with this PR

Note: Not all the PRs required examples and docs except a new pattern or add-on added.

For Moderators

  • E2E Test successfully complete before merge?

Additional Notes

@Zvikan Zvikan temporarily deployed to EKS Blueprints Test July 7, 2022 18:21 Inactive
@Zvikan Zvikan changed the title fix: unique event rules names per cluster id fix: unique NTH event rules names per cluster id Jul 7, 2022
askulkarni2
askulkarni2 approved these changes Jul 7, 2022
View reviewed changes
Copy link
Contributor

@askulkarni2 askulkarni2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome!

@Zvikan
Copy link
Contributor Author

Zvikan commented Jul 8, 2022 •
edited

Will re-run checks and merge (assuming all checks are green) once #746 or #745 merged.

@bryantbiggs bryantbiggs temporarily deployed to EKS Blueprints Test July 8, 2022 17:45 Inactive
@bryantbiggs bryantbiggs merged commit a95d7e0 into main Jul 8, 2022
@bryantbiggs bryantbiggs deleted the nth-eventbridge-rule-name-fix branch July 8, 2022 17:58
@bryantbiggs bryantbiggs mentioned this pull request Jul 8, 2022
Closed
1 task
allamand pushed a commit to allamand/terraform-aws-eks-blueprints that referenced this pull request Dec 15, 2022
@Zvikan @bryantbiggs @allamand
fix: unique NTH event rules names per cluster id (aws-ia#744)
eb1d701 
Co-authored-by: Bryant Biggs <bryantbiggs@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@askulkarni2 askulkarni2 askulkarni2 approved these changes

@bryantbiggs bryantbiggs bryantbiggs approved these changes

@kcoleman731 kcoleman731 Awaiting requested review from kcoleman731

@vara-bonthu vara-bonthu Awaiting requested review from vara-bonthu

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Zvikan @askulkarni2 @bryantbiggs