Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allows users to pass thier own secrets to Grafana admin #746

Merged
merged 6 commits into from
Jul 8, 2022

Conversation

vara-bonthu
Copy link
Contributor

@vara-bonthu vara-bonthu commented Jul 8, 2022

What does this PR do?

  • Allows users to pass their secret to grafana adminPassword field through set_sensitive values
  • Example added to create a new secret with Secrets Manager and pass that to Helm Chart

Motivation

More

  • Yes, I have tested the PR using my local account setup (Provide any test evidence report under Additional Notes)
  • Yes, I have added a new example under examples to support my PR
  • Yes, I have created another PR for add-ons under add-ons repo (if applicable)
  • Yes, I have updated the docs for this feature
  • Yes, I ran pre-commit run -a with this PR

Note: Not all the PRs required examples and docs except a new pattern or add-on added.

For Moderators

  • E2E Test successfully complete before merge?

Additional Notes

@vara-bonthu vara-bonthu temporarily deployed to EKS Blueprints Test July 8, 2022 11:49 Inactive
@Zvikan
Copy link
Contributor

Zvikan commented Jul 8, 2022

Thanks Vara, while I'm reviewing this can you please address the failed check

Copy link
Contributor

@Zvikan Zvikan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you for the fix, let's make sure all checks are green and happy.
Will also want to run the E2E on this example once merged, as this should work now with multiple applies since you used implicit dependencies for the secret manager.

@vara-bonthu vara-bonthu temporarily deployed to EKS Blueprints Test July 8, 2022 15:37 Inactive
Copy link
Contributor

@bryantbiggs bryantbiggs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks for this change!

@bryantbiggs bryantbiggs merged commit 994e846 into main Jul 8, 2022
@bryantbiggs bryantbiggs deleted the hotfix-grafana-adminpwd branch July 8, 2022 17:45
@alanty alanty mentioned this pull request Jul 18, 2022
6 tasks
allamand pushed a commit to allamand/terraform-aws-eks-blueprints that referenced this pull request Dec 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants