Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace terratest with terraform test #127

Merged
merged 12 commits into from
Nov 6, 2023
Merged

Replace terratest with terraform test #127

merged 12 commits into from
Nov 6, 2023

Conversation

drewmullen
Copy link
Contributor

@drewmullen drewmullen commented Jul 24, 2023 •
edited by pablo19sc

TODO:

  • upgrade pipeline to terraform v1.6
  • update commonly used tests to terraform test
  • Do we want to have pipelines automatically kick off terraform test?

Notes:

  • All tests have been replaced and are working except for cloud_wan which fails
  • There appear to be a few major bugs in 1.6, lets give them a couple weeks to work those out before merging this and upgrading the pipeline

@drewmullen drewmullen mentioned this pull request Jul 26, 2023
Closed
@drewmullen drewmullen mentioned this pull request Aug 11, 2023
Open
@drewmullen drewmullen mentioned this pull request Oct 5, 2023
Closed
@drewmullen drewmullen changed the title WIP: Prepatory PR to swap terratest with terraform test Replace terratest with terraform test Oct 5, 2023
pablo19sc
pablo19sc approved these changes Nov 3, 2023
View reviewed changes
Copy link
Collaborator

@pablo19sc pablo19sc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests done. All good

@tbulding tbulding merged commit 4a56893 into aws-ia:main Nov 6, 2023
@drewmullen drewmullen deleted the terraform-test-native branch January 25, 2024 15:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tbulding tbulding tbulding approved these changes

@pablo19sc pablo19sc pablo19sc approved these changes

@tonynv tonynv Awaiting requested review from tonynv tonynv is a code owner

@andrew-glenn andrew-glenn Awaiting requested review from andrew-glenn andrew-glenn is a code owner

@tlindsay42 tlindsay42 Awaiting requested review from tlindsay42 tlindsay42 is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@drewmullen @tbulding @pablo19sc