-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Simplify variable names #5
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looking good - couple of thoughts
data.tf
Outdated
@@ -1,12 +1,12 @@ | |||
data "vsphere_tag_category" "category" { | |||
count = !var.create_vsphere_tag_category && length(var.vsphere_tag_category_name) > 0 ? 1 : 0 | |||
count = !var.create_tag_category && length(var.tag_category_name) > 0 ? 1 : 0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
readability can be improved if you encapsulate the scope of conditions with ()
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done deal. Wrapped all conditions with parentheses
GetEnvOrExit(vsphere_user) | ||
GetEnvOrExit(vsphere_password) | ||
GetEnvOrExit(vsphere_server) | ||
GetEnvsOrExit() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
does it make sense to move invalid tests to their own file?
feel free to push back on this idea
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Started with this route but pivoted to consolidate as I needed to reuse the constants across all tests, so I thought it made more sense this way
No description provided.