Simplify variable names #5
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
drewmullen
suggested changes
Mar 17, 2022
data.tf
Outdated
| @@ -1,12 +1,12 @@ | |||
| data "vsphere_tag_category" "category" { | |||
| count = !var.create_vsphere_tag_category && length(var.vsphere_tag_category_name) > 0 ? 1 : 0 | |||
| count = !var.create_tag_category && length(var.tag_category_name) > 0 ? 1 : 0 | |||
There was a problem hiding this comment.
readability can be improved if you encapsulate the scope of conditions with ()
There was a problem hiding this comment.
Done deal. Wrapped all conditions with parentheses
| GetEnvOrExit(vsphere_user) | ||
| GetEnvOrExit(vsphere_password) | ||
| GetEnvOrExit(vsphere_server) | ||
| GetEnvsOrExit() |
There was a problem hiding this comment.
does it make sense to move invalid tests to their own file?
feel free to push back on this idea
There was a problem hiding this comment.
Started with this route but pivoted to consolidate as I needed to reuse the constants across all tests, so I thought it made more sense this way
drewmullen
approved these changes
Mar 17, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.