fix the collector fail to start issue after updated the new config deps #450
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pingleig
approved these changes
Apr 17, 2021
mxiamxia
changed the title
Codecov Report
@@ Coverage Diff @@
## main #450 +/- ##
=======================================
Coverage 82.72% 82.72%
=======================================
Files 6 6
Lines 110 110
=======================================
Hits 91 91
Misses 10 10
Partials 9 9 Continue to review full report at Codecov.
|
pingleig
reviewed
Apr 17, 2021
| @@ -45,3 +47,11 @@ func runService(params service.Parameters) error { | |||
|
|
|||
| return nil | |||
| } | |||
|
|
|||
| // Has to set exit code 0 for the fatal errors when run the collector as service in Windows | |||
There was a problem hiding this comment.
This is a new level of hack 😅 for #340
There was a problem hiding this comment.
any better idea? I think it seems better than previous one :)
There was a problem hiding this comment.
yeah, it's better than previous one from me (which didn't even work ...
done, thx |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Fix the new config interface error and taken care of windows exit code(0) issue