Update python-auto-instrumentation sample app and add to workflow #305
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erichsueh3
reviewed
Mar 21, 2023
| @@ -34,23 +35,25 @@ | |||
| # variable to keep track of the total number api requests | |||
| n = 0 | |||
|
|
|||
| common_attributes = { 'signal': 'metric', 'language': 'python-auto-instrumentation', 'metricType': 'request' } | |||
There was a problem hiding this comment.
Dumb question but what are these common_attributes used for, besides (what I assume to be) being required for the spec? I also notice that this is for metrics only, and for traces they are individually hardcoded for each span, is there a particular reason why this is?
There was a problem hiding this comment.
These common_attributes are tested for in the testcases for metrics as they are added to the metric instruments in the sample app when they are updated.
bryan-aguilar
approved these changes
Mar 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description: Update the python-auto-instrumentation sample app to fit the spec and then add it to the integ test workflow.
Testing Performed: Testing done on local and forked repo.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.