Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dry run validator before pull request #690

Merged
merged 21 commits into from
Jan 9, 2024
Merged
Show file tree
Hide file tree
Changes from 13 commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions .github/workflows/appsignals-e2e-ec2-canary-test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -4,9 +4,8 @@
## including logs, metrics, and traces.
name: App Signals Enablement - E2E EC2 Canary Testing
on:
schedule:
- cron: '0/15 * * * *' # run the workflow every 15 minutes
workflow_dispatch: # be able to run the workflow on demand
schedule:
- cron: '0/15 * * * *' # run the workflow every 15 minutes

permissions:
id-token: write
Expand Down
3 changes: 2 additions & 1 deletion .github/workflows/appsignals-e2e-ec2-test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@ on:
caller-workflow-name:
required: true
type: string
workflow_dispatch:

permissions:
id-token: write
Expand Down Expand Up @@ -241,4 +242,4 @@ jobs:
working-directory: testing/terraform/ec2
run: |
terraform destroy -auto-approve \
-var="test_id=${{ env.TESTING_ID }}"
-var="test_id=${{ env.TESTING_ID }}"
5 changes: 2 additions & 3 deletions .github/workflows/appsignals-e2e-eks-canary-test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -4,9 +4,8 @@
## including logs, metrics, and traces.
name: App Signals Enablement - E2E EKS Canary Testing
on:
schedule:
- cron: '0/15 * * * *' # run the workflow every 15 minutes
workflow_dispatch: # be able to run the workflow on demand
schedule:
- cron: '0/15 * * * *' # run the workflow every 15 minutes

concurrency:
group: ${{ github.workflow }}
Expand Down
5 changes: 5 additions & 0 deletions .github/workflows/pr-build.yml
Original file line number Diff line number Diff line change
Expand Up @@ -80,6 +80,11 @@ jobs:
gpg_private_key: ${{ secrets.GPG_PRIVATE_KEY }}
gpg_password: ${{ secrets.GPG_PASSPHRASE }}

- name: Dry Run Validator
if: ${{ matrix.os != 'windows-latest' }} # Skip dry run validator on windows as it is not possible to build opentelemetry-java on windows
run: |
./gradlew testing:validator:run --args='--dry-run-compile true'
XinRanZhAWS marked this conversation as resolved.
Show resolved Hide resolved

- name: Build with Gradle with Integration tests
uses: gradle/gradle-build-action@v2
if: ${{ matrix.os == 'ubuntu-latest' }}
Expand Down
10 changes: 10 additions & 0 deletions testing/validator/src/main/java/com/amazon/aoc/App.java
Original file line number Diff line number Diff line change
Expand Up @@ -138,6 +138,12 @@ public class App implements Callable<Integer> {
defaultValue = "")
private String instanceAmi;

@CommandLine.Option(
names = {"--dry-run-compile"},
defaultValue = "false"
)
private boolean dryRunCompile;

private static final String TEST_CASE_DIM_KEY = "testcase";
private static final String CANARY_NAMESPACE = "Otel/Canary";
private static final String CANARY_METRIC_NAME = "Success";
Expand All @@ -149,6 +155,10 @@ public static void main(String[] args) throws Exception {

@Override
public Integer call() throws Exception {
if (dryRunCompile) {
log.info("Dry Run Compile Success");
return null;
}
final Instant startTime = Instant.now();
// build context
Context context = new Context(this.testingId, this.region, this.isCanary, this.isRollup);
Expand Down
Loading