Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(ci): update layer ARN docs and create PR during release #2240

Merged

Conversation

heitorlessa
Copy link
Contributor

@heitorlessa heitorlessa commented May 11, 2023

Issue number: #2210

DEPENDENCY #2239

Summary

Use new create-pr action introduced in #2238 to create a PR with latest Layer ARNs in the docs instead of pushing directly to develop as part of the release.

Changes

Please provide a summary of what's being changed

  • Propagate and scope permissions from release.yml workflow
  • Remove docs publishing responsibility from reusable_deploy_v2_layer_stack.yml
  • Split release_docs job in publish_v2_layer.yml workflow to: (1) create PR and, (2) deploy to latest released docs from PR temp branch
  • Document Layer Docs split (PR+Deploy from temp branch) and why
  • Remove now redundant reusable_update_v2_layer_arn_docs.yml
  • Update CHANGELOG with latest git tag available during release for the newly released docs

User experience

Please share what the user experience looks like before and after this change

Checklist

If your change doesn't seem to apply, please leave them unchecked.

Is this a breaking change?

RFC issue number:

Checklist:

  • Migration process documented
  • Implement warnings (if it can live side by side)

Acknowledgment

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.

Signed-off-by: heitorlessa <lessa@amazon.co.uk>
Signed-off-by: heitorlessa <lessa@amazon.co.uk>
Signed-off-by: heitorlessa <lessa@amazon.co.uk>
Signed-off-by: heitorlessa <lessa@amazon.co.uk>
Signed-off-by: heitorlessa <lessa@amazon.co.uk>
Signed-off-by: heitorlessa <lessa@amazon.co.uk>
Signed-off-by: heitorlessa <lessa@amazon.co.uk>
Signed-off-by: heitorlessa <lessa@amazon.co.uk>
Signed-off-by: heitorlessa <lessa@amazon.co.uk>
Signed-off-by: heitorlessa <lessa@amazon.co.uk>
Signed-off-by: heitorlessa <lessa@amazon.co.uk>
@heitorlessa heitorlessa requested a review from a team as a code owner May 11, 2023 14:42
@heitorlessa heitorlessa requested review from rubenfonseca and removed request for a team May 11, 2023 14:43
@boring-cyborg boring-cyborg bot added the github-actions Pull requests that update Github_actions code label May 11, 2023
@pull-request-size pull-request-size bot added the size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. label May 11, 2023
@github-actions github-actions bot added internal Maintenance changes labels May 11, 2023
@heitorlessa heitorlessa mentioned this pull request May 11, 2023
20 tasks
@heitorlessa heitorlessa requested review from leandrodamascena and removed request for rubenfonseca May 12, 2023 13:36
* develop:
  chore(ci): bump package version after release via pull request (aws-powertools#2239)
  chore(ci): convert create-pr steps into composite action (aws-powertools#2238)
  chore(ci): changelog rebuild (aws-powertools#2241)
  chore(deps-dev): bump aws-cdk from 2.78.0 to 2.79.0 (aws-powertools#2235)
  docs(batch_processing): snippets split, improved, and lint (aws-powertools#2231)
  chore(deps-dev): bump mypy from 1.2.0 to 1.3.0 (aws-powertools#2233)
@pull-request-size pull-request-size bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels May 12, 2023
heitorlessa and others added 4 commits May 12, 2023 16:32
Signed-off-by: Heitor Lessa <lessa@amazon.nl>
Signed-off-by: Heitor Lessa <lessa@amazon.nl>
Signed-off-by: heitorlessa <lessa@amazon.co.uk>
Copy link
Contributor

@leandrodamascena leandrodamascena left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AMAZING WORK!!!

@leandrodamascena leandrodamascena merged commit 5b14452 into aws-powertools:develop May 12, 2023
3 checks passed
@heitorlessa heitorlessa deleted the chore/update-layer-arn-pr branch May 12, 2023 15:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
github-actions Pull requests that update Github_actions code internal Maintenance changes size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants