-
Notifications
You must be signed in to change notification settings - Fork 368
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(ci): update layer ARN docs and create PR during release #2240
Merged
leandrodamascena
merged 20 commits into
aws-powertools:develop
from
heitorlessa:chore/update-layer-arn-pr
May 12, 2023
Merged
chore(ci): update layer ARN docs and create PR during release #2240
leandrodamascena
merged 20 commits into
aws-powertools:develop
from
heitorlessa:chore/update-layer-arn-pr
May 12, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: heitorlessa <lessa@amazon.co.uk>
Signed-off-by: heitorlessa <lessa@amazon.co.uk>
Signed-off-by: heitorlessa <lessa@amazon.co.uk>
Signed-off-by: heitorlessa <lessa@amazon.co.uk>
Signed-off-by: heitorlessa <lessa@amazon.co.uk>
Signed-off-by: heitorlessa <lessa@amazon.co.uk>
Signed-off-by: heitorlessa <lessa@amazon.co.uk>
Signed-off-by: heitorlessa <lessa@amazon.co.uk>
Signed-off-by: heitorlessa <lessa@amazon.co.uk>
Signed-off-by: heitorlessa <lessa@amazon.co.uk>
Signed-off-by: heitorlessa <lessa@amazon.co.uk>
boring-cyborg
bot
added
the
github-actions
Pull requests that update Github_actions code
label
May 11, 2023
pull-request-size
bot
added
the
size/XL
Denotes a PR that changes 500-999 lines, ignoring generated files.
label
May 11, 2023
20 tasks
heitorlessa
requested review from
leandrodamascena
and removed request for
rubenfonseca
May 12, 2023 13:36
* develop: chore(ci): bump package version after release via pull request (aws-powertools#2239) chore(ci): convert create-pr steps into composite action (aws-powertools#2238) chore(ci): changelog rebuild (aws-powertools#2241) chore(deps-dev): bump aws-cdk from 2.78.0 to 2.79.0 (aws-powertools#2235) docs(batch_processing): snippets split, improved, and lint (aws-powertools#2231) chore(deps-dev): bump mypy from 1.2.0 to 1.3.0 (aws-powertools#2233)
pull-request-size
bot
added
size/L
Denotes a PR that changes 100-499 lines, ignoring generated files.
and removed
size/XL
Denotes a PR that changes 500-999 lines, ignoring generated files.
labels
May 12, 2023
heitorlessa
commented
May 12, 2023
heitorlessa
commented
May 12, 2023
heitorlessa
commented
May 12, 2023
Signed-off-by: Heitor Lessa <lessa@amazon.nl>
Signed-off-by: Heitor Lessa <lessa@amazon.nl>
Signed-off-by: heitorlessa <lessa@amazon.co.uk>
leandrodamascena
approved these changes
May 12, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
AMAZING WORK!!!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
github-actions
Pull requests that update Github_actions code
internal
Maintenance changes
size/L
Denotes a PR that changes 100-499 lines, ignoring generated files.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue number: #2210
DEPENDENCY #2239
Summary
Use new create-pr action introduced in #2238 to create a PR with latest Layer ARNs in the docs instead of pushing directly to develop as part of the release.
Changes
release.yml
workflowreusable_deploy_v2_layer_stack.yml
release_docs
job inpublish_v2_layer.yml
workflow to: (1) create PR and, (2) deploy to latest released docs from PR temp branchreusable_update_v2_layer_arn_docs.yml
User experience
Checklist
If your change doesn't seem to apply, please leave them unchecked.
Is this a breaking change?
RFC issue number:
Checklist:
Acknowledgment
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.