chore(ci): bump package version after release via pull request #2239
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: heitorlessa <lessa@amazon.co.uk>
Signed-off-by: heitorlessa <lessa@amazon.co.uk>
Signed-off-by: heitorlessa <lessa@amazon.co.uk>
Signed-off-by: heitorlessa <lessa@amazon.co.uk>
Signed-off-by: heitorlessa <lessa@amazon.co.uk>
Signed-off-by: heitorlessa <lessa@amazon.co.uk>
Signed-off-by: heitorlessa <lessa@amazon.co.uk>
heitorlessa
requested review from
leandrodamascena
and removed request for
a team
boring-cyborg
bot
added
the
github-actions
pull-request-size
bot
added
the
size/L
13 tasks
20 tasks
leandrodamascena
requested changes
May 12, 2023
.github/workflows/release.yml
Outdated
Comment on lines
146
to
147
| contents: write | ||
| pull-requests: write |
There was a problem hiding this comment.
Are these permissions not conflicting with each other? I think the pull-requests: write permission is enough for that, no? The contents: write permission seems to be much broader and allows things we don't need.
References:
https://docs.github.com/en/rest/overview/permissions-required-for-github-apps?apiVersion=2022-11-28#pull-requests
https://docs.github.com/en/rest/overview/permissions-required-for-github-apps?apiVersion=2022-11-28#contents
There was a problem hiding this comment.
Not in this case :)
create-pr action needs to create a temporary branch to push these staged files (pyproject.toml) - hence contents: write. Then, creates a PR against develop using our temporary branch as the HEAD - hence pull-requests: write
pull-request-size
bot
added
size/M
heitorlessa
commented
May 12, 2023
.github/workflows/release.yml
Outdated
| bump_version: | ||
| needs: [build, release] | ||
| permissions: | ||
| contents: write |
There was a problem hiding this comment.
Suggested change
| contents: write | |
| contents: write # create-pr action creates a temporary branch |
heitorlessa
commented
May 12, 2023
heitorlessa
commented
May 12, 2023
Signed-off-by: Heitor Lessa <lessa@amazon.nl>
Signed-off-by: Heitor Lessa <lessa@amazon.nl>
heitorlessa
added a commit
to heitorlessa/aws-lambda-powertools-python
that referenced
this pull request
May 12, 2023
* develop: chore(ci): bump package version after release via pull request (aws-powertools#2239) chore(ci): convert create-pr steps into composite action (aws-powertools#2238) chore(ci): changelog rebuild (aws-powertools#2241) chore(deps-dev): bump aws-cdk from 2.78.0 to 2.79.0 (aws-powertools#2235) docs(batch_processing): snippets split, improved, and lint (aws-powertools#2231) chore(deps-dev): bump mypy from 1.2.0 to 1.3.0 (aws-powertools#2233)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue number: #2210
DEPENDENCY: #2238
Summary
Use new create-pr action introduced in #2238 to bump package version via PR instead of pushing directly to
developas part of the release.Changes
bump_versionwith scoped permissions to do exactly thatbuildjob as it no longer needs to push todevelopchangelogjob as it's now handled perfectly in every push via PR - introduced in chore(ci): convert create-pr steps into composite action #2238User experience
Checklist
If your change doesn't seem to apply, please leave them unchecked.
Is this a breaking change?
RFC issue number:
Checklist:
Acknowledgment
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.