Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature request: Support Middy 4.x #1694

Closed
1 of 2 tasks
mk0sojo opened this issue Sep 19, 2023 · 5 comments · Fixed by #1760
Closed
1 of 2 tasks

Feature request: Support Middy 4.x #1694

mk0sojo opened this issue Sep 19, 2023 · 5 comments · Fixed by #1760
Assignees
Labels
completed This item is complete and has been merged/shipped feature-request This item refers to a feature request for an existing or new utility
Milestone

Comments

@mk0sojo
Copy link

mk0sojo commented Sep 19, 2023

Use case

Middy 4 has been out quite long and if using lambda with Node 18, we want to use Middy 4 because of the AWS SDK v3 support.
Is there any plans to support Middy 4?

Sorry if this is a duplicate, but couldn't find any similar feature request.

Solution/User Experience

Upgrade middy package

Alternative solutions

No response

Acknowledgment

Future readers

Please react with 👍 and your use case to help us understand customer demand.

@mk0sojo mk0sojo added triage This item has not been triaged by a maintainer, please wait feature-request This item refers to a feature request for an existing or new utility labels Sep 19, 2023
@boring-cyborg
Copy link

boring-cyborg bot commented Sep 19, 2023

Thanks for opening your first issue here! We'll come back to you as soon as we can.
In the meantime, check out the #typescript channel on our Powertools for AWS Lambda Discord: Invite link

@dreamorosi
Copy link
Contributor

Hi @mk0sojo thanks for opening the issue.

The current latest version of Powertools for AWS supports all currently available Node.js AWS Lambda runtimes: nodejs14x, nodejs16x, and nodejs18x.

With version 4.x Middy dropped support of Node.js 14, which prevents us from recommending it to all our customers since we can't reliably run integration tests on that runtime.

We are aware that Node.js 14 has reached EOL but for the time being we have aligned our runtimes (aka Node.js versions) support with Lambda. This means that we'll drop support for this version in the coming weeks as announced in #1664.

Shortly after that we'll likely also start recommending Middy 4.x.

In any case, we only really rely on @middy/core, which at the best of my knowledge hasn't introduced any breaking change between versions 3.x and 4.x, so if using Node.js 16 or newer you should be able to use it with Powertools.

@dreamorosi dreamorosi added blocked This item's progress is blocked by external dependency or reason dependencies and removed triage This item has not been triaged by a maintainer, please wait labels Sep 19, 2023
@dreamorosi dreamorosi added this to the Version 2.0 milestone Sep 19, 2023
@mk0sojo
Copy link
Author

mk0sojo commented Sep 20, 2023

While @middy/core doesn't rely on the AWS SDK, a lot of other middy middlewares does and since v.4 they use AWS SDK v3 rather than AWS SDK v2, for example, the SSM middleware (https://middy.js.org/docs/upgrade/3-4/#ssm). So as part of our upgrade from Node 16 to Node 18 (and AWS SDK v2 to v3). We will therefor hold off using the lambda powertools until Middy 4 is supported.

@dreamorosi dreamorosi self-assigned this Oct 20, 2023
@dreamorosi dreamorosi added confirmed The scope is clear, ready for implementation and removed blocked This item's progress is blocked by external dependency or reason labels Oct 20, 2023
@dreamorosi dreamorosi linked a pull request Oct 20, 2023 that will close this issue
9 tasks
@github-actions
Copy link
Contributor

⚠️ COMMENT VISIBILITY WARNING ⚠️

Comments on closed issues are hard for our team to see.
If you need more assistance, please either tag a team member or open a new issue that references this one.
If you wish to keep having a conversation with other community members under this issue feel free to do so.

@dreamorosi dreamorosi added pending-release This item has been merged and will be released soon and removed confirmed The scope is clear, ready for implementation labels Oct 20, 2023
@github-actions github-actions bot added completed This item is complete and has been merged/shipped and removed pending-release This item has been merged and will be released soon labels Nov 1, 2023
@aws-powertools aws-powertools deleted a comment from github-actions bot Nov 2, 2023
@dreamorosi dreamorosi added pending-release This item has been merged and will be released soon completed This item is complete and has been merged/shipped and removed completed This item is complete and has been merged/shipped pending-release This item has been merged and will be released soon labels Nov 2, 2023
@dreamorosi
Copy link
Contributor

This is available in preview starting from the 2.0.0-alpha.1 release. You can install this version using the next tag, i.e. npm i @aws-lambda-powertools/logger@next.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
completed This item is complete and has been merged/shipped feature-request This item refers to a feature request for an existing or new utility
Projects
Development

Successfully merging a pull request may close this issue.

2 participants