Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature request: Support Middy 5.x #2049

Open
1 of 2 tasks
saragerion opened this issue Feb 11, 2024 · 2 comments
Open
1 of 2 tasks

Feature request: Support Middy 5.x #2049

saragerion opened this issue Feb 11, 2024 · 2 comments
Labels
feature-request This item refers to a feature request for an existing or new utility need-customer-feedback Requires more customers feedback before making or revisiting a decision on-hold This item is on-hold and will be revisited in the future revisit-in-3-months Blocked issues/PRs that need to be revisited

Comments

@saragerion
Copy link
Contributor

Use case

This feature request is about an upcoming official support of Middy 5.x.

The current Powertools version 1.18.0 officially supports Middy up until version 3, as described in the documentation.

Support for Middy v4 is expected to be launched soon as part of the upcoming major release 2.x.

If and when Middy v5 will be officially supported, it would be good to guide developers on what changes they need to implement in their codebase to successfully leverage the Logger utility together with Middy v5.

Solution/User Experience

Upgrading to Middy v5 may have a significant impact on the codebase and developer experience.
See Middy's documentation for more info.

Alternative solutions

No response

Acknowledgment

Future readers

Please react with 👍 and your use case to help us understand customer demand.

@saragerion saragerion added triage This item has not been triaged by a maintainer, please wait feature-request This item refers to a feature request for an existing or new utility labels Feb 11, 2024
@dreamorosi
Copy link
Contributor

Hi @saragerion thank you for opening this issue.

At the moment we don't have concrete plans for officially supporting Middy.js v5, however when the time comes I expect there will be challenges due to Powertools supporting both CJS and ESM and Middy.js having dropped support for the former in their v5 major version.

According to our versioning policy we are committed to supporting all current AWS Lambda managed runtimes, which at the time of writing are the ones corresponding to Node.js 16 through Node.js 20.

On Middy.js side, their release cadence aligns more closely with the Node.js LTS policy. This means that v5 dropped support for Node.js 16.

For the time being, I'd suggest customers to stick with v4 if they're using mainly the @middy/core module (the only one required by Powertools' middlewares), as suggested by Middy.js own maintainer.

With this in mind, and according to the latest info publicly available on the AWS Lambda Runtime versioning policy, the earliest we can consider support for Middy.js 5x is going to be late Q2/early Q3, which is when we're expected to also drop support for Node.js 16.

I'm going to mark this as an item to revisit in the next quarter, but it would be useful for us to have customers interested in the feature react with a 👍 to this issue as this will help us understand demand.

@dreamorosi dreamorosi added on-hold This item is on-hold and will be revisited in the future need-customer-feedback Requires more customers feedback before making or revisiting a decision revisit-in-3-months Blocked issues/PRs that need to be revisited and removed triage This item has not been triaged by a maintainer, please wait labels Feb 12, 2024
@dreamorosi dreamorosi changed the title Feature request (Logger): Support Middy 5.x Feature request: Support Middy 5.x Mar 6, 2024
@OffensiveBias-08-145
Copy link

To add to this, a number of issues regarding middy v5 have been popping up as of late.

There are a number of type conflicts and issues with bundling middy v5 using various frameworks.

Revisiting in another couple of months seems like a good next step.

middyjs/middy#1208

middyjs/middy#1147

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature-request This item refers to a feature request for an existing or new utility need-customer-feedback Requires more customers feedback before making or revisiting a decision on-hold This item is on-hold and will be revisited in the future revisit-in-3-months Blocked issues/PRs that need to be revisited
Projects
Development

No branches or pull requests

3 participants