Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(parameters): Tokenize attribute names in DynamoDBProvider #1239

Merged
merged 4 commits into from
Jan 13, 2023

Conversation

dreamorosi
Copy link
Contributor

Description of your changes

As described in the linked issue, the DynamoDBProvider is not currently tokenizing attribute names that contain any of the DynamoDB reserved words. This should be done by using ExpressionAttributeNames in the queries.

This PR makes this change, which will fix #1238.

How to verify this change

See updated unit tests that include reserved words and assert that they are tokenized correctly.

Related issues, RFCs

Issue number: #1238

PR status

Is this ready for review?: YES
Is it a breaking change?: NO

Checklist

  • My changes meet the tenets criteria
  • I have performed a self-review of my own code
  • I have commented my code where necessary, particularly in areas that should be flagged with a TODO, or hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding changes to the examples
  • My changes generate no new warnings
  • The code coverage hasn't decreased
  • I have added tests that prove my change is effective and works
  • New and existing unit tests pass locally and in Github Actions
  • Any dependent changes have been merged and published
  • The PR title follows the conventional commit semantics

Breaking change checklist

  • I have documented the migration process
  • I have added, implemented necessary warnings (if it can live side by side)

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@dreamorosi dreamorosi self-assigned this Jan 13, 2023
@pull-request-size pull-request-size bot added the size/M PR between 30-99 LOC label Jan 13, 2023
@github-actions github-actions bot added the bug Something isn't working label Jan 13, 2023
@dreamorosi dreamorosi merged commit f3e5ed7 into main Jan 13, 2023
@dreamorosi dreamorosi deleted the fix/parameters/dynamodbprovider branch January 13, 2023 15:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working size/M PR between 30-99 LOC
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: DynamoDBProvider not tokenizing projection values/names correctly
1 participant