Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] Build files contain CFN tokens until stack is updated #184

Closed
cartalla opened this issue Dec 21, 2023 · 0 comments · Fixed by #187
Closed

[BUG] Build files contain CFN tokens until stack is updated #184

cartalla opened this issue Dec 21, 2023 · 0 comments · Fixed by #187
Assignees
@cartalla

Comments

@cartalla
Copy link
Contributor

Describe the bug

The build files are currently built with the cdk stack so resources like security groups and IAM policies don't exist yet.
There is code to get those IDs on an update, but the files should really be correct after initial deployment.

Propose to create them in a Lambda custom resource with the resource IDs passed as parameters so that they are resolved
during CFN deployment.

The ParallelCluster custom resource should depend on the build-files since it will download the build files from S3.
@cartalla cartalla self-assigned this Dec 21, 2023
cartalla added a commit that referenced this issue Dec 29, 2023
@cartalla
Use lambda to create build configuration files
417bc14 
Otherwise they contain CloudFormation tokens for resources used during deployment.

Limit Rocky 8 to 8.8 since 8.9 fails because lustre client isn't suported.

Resolves #184
cartalla added a commit that referenced this issue Dec 29, 2023
@cartalla
Use lambda to create build configuration files
1e164e8 
Otherwise they contain CloudFormation tokens for resources used during deployment.

Limit Rocky 8 to 8.8 since 8.9 fails because lustre client isn't suported.

Resolves #184
Resolves #185
cartalla added a commit that referenced this issue Jan 2, 2024
@cartalla
Use lambda to create build configuration files
f043e46 
Otherwise they contain CloudFormation tokens for resources used during deployment.

Limit Rocky 8 to 8.8 since 8.9 fails because lustre client isn't suported.

Resolves #184
Resolves #185
cartalla added a commit that referenced this issue Jan 2, 2024
@cartalla
Use lambda to create build configuration files
36f4ea8 
Otherwise they contain CloudFormation tokens for resources used during deployment.

Limit Rocky 8 to 8.8 since 8.9 fails because lustre client isn't suported.

Resolves #184
Resolves #185
cartalla added a commit that referenced this issue Jan 4, 2024
@cartalla
Use lambda to create build configuration files
5a7544b 
Otherwise they contain CloudFormation tokens for resources used during deployment.

Limit Rocky 8 to 8.8 since 8.9 fails because lustre client isn't suported.

Check AMI support for instance types.
Rocky 8 doesn't currently support the gen7 AMD instance types.

Resolves #184
Resolves #185
Resolves #186
cartalla added a commit that referenced this issue Jan 5, 2024
@cartalla
Use lambda to create build configuration files
4d9dc70 
Otherwise they contain CloudFormation tokens for resources used during deployment.

Limit Rocky 8 to 8.8 since 8.9 fails because lustre client isn't suported.

Check AMI support for instance types.
Rocky 8 doesn't currently support the gen7 AMD instance types.

Publish to ErrorSnsTopicArn when a lambda fails.

Resolves #184
Resolves #185
Resolves #186
@cartalla cartalla linked a pull request Jan 5, 2024 that will close this issue
Use lambda to create build configuration files #187
Merged
@cartalla cartalla mentioned this issue Jan 5, 2024
Merged
cartalla added a commit that referenced this issue Jan 5, 2024
@cartalla
Use lambda to create build configuration files (#187)
2a18cc2 
Otherwise they contain CloudFormation tokens for resources used during deployment.

Limit Rocky 8 to 8.8 since 8.9 fails because lustre client isn't suported.

Check AMI support for instance types.
Rocky 8 doesn't currently support the gen7 AMD instance types.

Publish to ErrorSnsTopicArn when a lambda fails.

Resolves #184
Resolves #185
Resolves #186
@cartalla cartalla mentioned this issue Apr 2, 2024
Closed
cartalla added a commit that referenced this issue Apr 2, 2024
@cartalla
Remove creation of local AMI build-files
34a6ec6 
They are now generated in a lambda and downloaded to the head node.

Related to #184.

Resolves #216
cartalla added a commit that referenced this issue Apr 2, 2024
@cartalla
Remove creation of local AMI build-files
e6ec919 
They are now generated in a lambda and downloaded to the head node.

Related to #184.

Resolves #216
@cartalla cartalla mentioned this issue Apr 2, 2024
Merged
cartalla added a commit that referenced this issue Apr 2, 2024
@cartalla
Remove creation of local AMI build-files
3ee6578 
They are now generated in a lambda and downloaded to the head node.

Related to #184.

Resolves #216
cartalla added a commit that referenced this issue Apr 2, 2024
@cartalla
Remove creation of local AMI build-files (#217)
2e334c2 
They are now generated in a lambda and downloaded to the head node.

Related to #184.

Resolves #216
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@cartalla cartalla

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Use lambda to create build configuration files aws-samples/aws-eda-slurm-cluster
1 participant
@cartalla