Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

poll_delete - Breaks with Large Bot Definitions #1

Open
jessedoyle opened this issue Sep 23, 2021 · 0 comments
Open

poll_delete - Breaks with Large Bot Definitions #1

jessedoyle opened this issue Sep 23, 2021 · 0 comments

Comments

@jessedoyle
Copy link

jessedoyle commented Sep 23, 2021 •
edited

Hi there!

Thanks for making such a great resource - we've always struggled with Lex tooling in the past, so it's great to see others providing options and custom resources!

It looks like a previous commit removed the poll_create and poll_update functions due to limitations with rule payload sizes.

I see the poll_delete function still exists though. Was it missed?

We're able to build a rather large bot, but it fails to delete or roll back properly if there's an error in the stack.

Here's the error message we're getting:

Received response status [FAILED] from custom resource.

Message returned: ERROR: (truncated) , "CrHelperRule": "arn:aws:events:us-east-1:123456789000:rule/LexBotExample", "CrHelperPermission": "LexBotExample"}' at 'targets.1.member.input' failed to satisfy constraint: 

Member must have length less than or equal to 8192

Is there a way this error can be resolved?

Thanks!
jessedoyle pushed a commit to jessedoyle/aws-lex-v2-cfn-cr that referenced this issue Sep 24, 2021
fix(delete): Remove Deletion Polling
3160103 
* There is an 8KB limit to `AWS::Events::Rule` resources that are
  created by the  `crhelper` library to implement a polling
  strategy for the custom resource.
* The polling strategies for `update` and `create` were previously
  removed in commit ad497ce, but
  the `poll_delete` function was not removed.
* For larger bot definitions (ie. > 8KB), the custom resource
  correctly creates and updates the bot resource, but it will
  fail on deletion with an error message of:

```
'targets.1.member.input' failed to satisfy constraint:

Member must have length less than or equal to 8192
```
* To resolve this issue, simply remove the `poll_delete` function
  and update the `delete_resource` function to wait for the bot
  and the bot alias to be fully deleted.

resolves: aws-samples#1
@jessedoyle jessedoyle mentioned this issue Sep 24, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(delete): Remove Deletion Polling jessedoyle/aws-lex-v2-cfn-cr
1 participant
@jessedoyle