fix(delete): Remove Deletion Polling #2
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
September 24, 2021 11:53
* There is an 8KB limit to `AWS::Events::Rule` resources that are created by the `crhelper` library to implement a polling strategy for the custom resource. * The polling strategies for `update` and `create` were previously removed in commit ad497ce, but the `poll_delete` function was not removed. * For larger bot definitions (ie. > 8KB), the custom resource correctly creates and updates the bot resource, but it will fail on deletion with an error message of: ``` 'targets.1.member.input' failed to satisfy constraint: Member must have length less than or equal to 8192 ``` * To resolve this issue, simply remove the `poll_delete` function and update the `delete_resource` function to wait for the bot and the bot alias to be fully deleted. resolves: aws-samples#1
* Resolve lint violations that were flagged when running the `lint` make target.
|
Pinging @atoa - it looks like you have created all the commits in this repo. Please let me know what you think of the change, I'm happy to make any modifications! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi there! We noticed an issue deleting Lex bot resources when using this custom resource due to the polling/async behaviour in the
crhelperlibrary.I've tested the changes in the PR against our own larger bot definition and they seem to correctly delete the resource with the polling strategy removed.
Issue #, if available:
resolves: #1
Description of changes:
AWS::Events::Ruleresources that arecreated by the
crhelperlibrary to implement a pollingstrategy for the custom resource.
updateandcreatewere previouslyremoved in commit ad497ce, but
the
poll_deletefunction was not removed.correctly creates and updates the bot resource, but it will
fail on deletion with an error message of:
poll_deletefunctionand update the
delete_resourcefunction to wait for the botand the bot alias to be fully deleted.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.