updates to the dynamic reference lab templates \ module #195
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mrinaudo-aws
reviewed
Apr 2, 2023
ctd
approved these changes
Apr 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do and why?
Describe in detail what your merge request does and why.
Matteo brought to my attention about an issue with the lab templates re: DeletionPolicy. By default, the DeletionPolicy attribute uses Delete . However, there is an exception (see Note Exception in the page) for RDS. As a result, when running the
database.yamltemplate in the lab above (this template is present in both the workspace and solutions relevant subdirectories), a snapshot on delete will be created and persisted in the account and region.This fix explicitly sets the DeletionPolicy to Delete attached to the RDS resource and explains the policy choice in the module.
PR acceptance checklist
This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.
make version part=<major|minor|patch>?By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.