Cloud9 cfn template #198
Cloud9 cfn template #198
Conversation
There was a problem hiding this comment.
I would recommend to remove cfn Cloud9 support as the template needs quite a bit of work. I would suggest to move the part where we create C9 via CFN to own PR so we can go and publish these pre-req.
This will allow us to move forward with individual labs and test them in C9 created in console.
The automation part, even thou is nice to have and will definitely help out, we need to make sure it is not blocking us moving forward
| Description: | ||
| AWS CloudFormation template for dynamic Cloud 9 setups. Creates a Cloud9 | ||
| bootstraps the instance. |
There was a problem hiding this comment.
| Description: | |
| AWS CloudFormation template for dynamic Cloud 9 setups. Creates a Cloud9 | |
| bootstraps the instance. | |
| Description: | |
| AWS CloudFormation workshop - Cloud9 IDE (uksb-1q9p31idr). |
| BucketName: | ||
| Type: String | ||
| Default: "cfn-workshop-01-123456789 " |
There was a problem hiding this comment.
We should not explicitly name buckets. Let cfn to generate name and output the value in Outputs.
There was a problem hiding this comment.
We should not explicitly name buckets. Let cfn to generate name and output the value in
Outputs.
Will handle it in new pr
| AllowedValues: | ||
| - t2.micro | ||
| - t3.micro | ||
| - t3.small | ||
| - t3.medium | ||
| ConstraintDescription: Must be a valid Cloud9 instance type |
There was a problem hiding this comment.
we should not restrict to only t instances, either support all here or I would remove and let user to decide what they want. I am suggesting t3.micro as default as it is free tier.
There was a problem hiding this comment.
we should not restrict to only t instances, either support all here or I would remove and let user to decide what they want. I am suggesting
t3.microas default as it is free tier.
will remove list and default to t3.micro in new pr
| C9InstanceType: | ||
| Description: Cloud9 instance type | ||
| Type: String | ||
| Default: t3.small |
There was a problem hiding this comment.
| Default: t3.small | |
| Default: t3.micro |
| C9EnvType: | ||
| Description: Environment type. | ||
| Default: self | ||
| Type: String | ||
| AllowedValues: | ||
| - self | ||
| - 3rdParty | ||
| ConstraintDescription: must specify self or 3rdParty. |
There was a problem hiding this comment.
What does this does? I didn't see anything in deployment instructions what self and 3rd party means...do we need user to make choice if we are saying leave all properties default?
There was a problem hiding this comment.
What does this does? I didn't see anything in deployment instructions what self and 3rd party means...do we need user to make choice if we are saying leave all properties default?
we do not need any of these
There was a problem hiding this comment.
this doesnt seem to be used anywhere?
There was a problem hiding this comment.
this doesnt seem to be used anywhere?
yes, earlier this page had images, not needed anymore, removed
There was a problem hiding this comment.
this doesn't seem to be used anywhere?
There was a problem hiding this comment.
this doesn't seem to be used anywhere?
yes, earlier this page had images, not needed anymore, removed
There was a problem hiding this comment.
this doesn't seem to be used anywhere?
There was a problem hiding this comment.
this doesn't seem to be used anywhere?
yes, earlier this page had images, not needed anymore, removed
There was a problem hiding this comment.
this doesn't seem to be used anywhere?
There was a problem hiding this comment.
this doesn't seem to be used anywhere?
yes, earlier this page had images, not needed anymore, removed
There was a problem hiding this comment.
this doesn't seem to be used anywhere?
There was a problem hiding this comment.
this doesn't seem to be used anywhere?
yes, earlier this page had images, not needed anymore, removed
|
I have moved |
|
|
||
| [AWS Cloud9](https://aws.amazon.com/cloud9/) is a cloud-based IDE that lets you write, run, and debug your code with just a browser. It includes a code editor, debugger, and terminal. Cloud9 comes prepackaged with essential tools for running this workshop. Since your Cloud9 IDE is cloud-based, you can do labs from your office, home, or anywhere using an internet-connected machine. | ||
|
|
||
| We recommend using it to run this workshop because it comes with the necessary set of tools pre-installed. If you prefer to work locally, the next section includes details on how to setup your local development environment. |
There was a problem hiding this comment.
We need to be more specific here. Out of the box the C9 comes with following tools relevant to the workshop:
- Pyhton
- pip
- awscli
|
|
||
| [AWS Cloud9](https://aws.amazon.com/cloud9/) is a cloud-based IDE that lets you write, run, and debug your code with just a browser. It includes a code editor, debugger, and terminal. Cloud9 comes prepackaged with essential tools for running this workshop. Since your Cloud9 IDE is cloud-based, you can do labs from your office, home, or anywhere using an internet-connected machine. | ||
|
|
||
| We recommend using it to run this workshop because it comes with the necessary set of tools pre-installed. If you prefer to work locally, the next section includes details on how to setup your local development environment. |
There was a problem hiding this comment.
I think the should reword little bit. Something like, "For the best experience with the workshop and minimal setup effort, we recommend..."
| We recommend using **us-east-1 (N. Virginia)** as the _AWS Region_ for the workshop. | ||
| ::: | ||
| 1. Once created, your instance should be listed on the AWS Cloud9 [Environments](https://console.aws.amazon.com/cloud9/home) page. Click **Open** if not already. | ||
| 1. You will see a terminal area at the bottom where you will run the commands as you progress through the workshop. In the main work area you will open and edit code and template files. AWS Cloud9 comes with the required command line tools (aws cli, python) pre-installed. |
There was a problem hiding this comment.
| 1. You will see a terminal area at the bottom where you will run the commands as you progress through the workshop. In the main work area you will open and edit code and template files. AWS Cloud9 comes with the required command line tools (aws cli, python) pre-installed. | |
| 1. You will see a terminal area at the bottom where you will run the commands as you progress through the workshop. In the main work area you will open and edit code and template files. |
| 1. There is one tool to update, run below command on terminal to update the **pip** version: | ||
| :::code{language=shell showLineNumbers=false showCopyAction=true} | ||
| sudo pip install --upgrade pip | ||
| ::: |
There was a problem hiding this comment.
why we upgrading pip? also running sudo is not a good practices with a pip...it should be run as a user rather root...
There was a problem hiding this comment.
maybe as a final step customers can test that aws cli is working by running aws s3 ls...i think that's all needed at this stage?
There was a problem hiding this comment.
actually we should have section for cloning the repo here as it is different to local...and we can move git instructions to the local development
There was a problem hiding this comment.
I have notice that you have updated Get lab resources section...lets move it here and we can move rest of that file to local development
There was a problem hiding this comment.
why we upgrading pip? also running
sudois not a good practices with a pip...it should be run as a user rather root...
without pip upgrade pip install cfn-lint do not work as default pip is older version and fails while installing cfn-lint
There was a problem hiding this comment.
I have notice that you have updated Get lab resources section...lets move it here and we can move rest of that file to local development
done, please have a look and share your suggestions
There was a problem hiding this comment.
lets move this to c9 content
There was a problem hiding this comment.
lest get rid of this file and move relevant content to C9 and LocalDev as appropriate...that will simplify pre-req section a lot. We will have folowing structure:
- Create an AWS Account
- Use Cloud9 IDE
- Use Local Development
- Default VPC
| @@ -0,0 +1,96 @@ | |||
| --- | |||
| title: "Use local development" | |||
There was a problem hiding this comment.
| title: "Use local development" | |
| title: "Use Local Development" |
|
Closing this one in favor of #215 |
What does this PR do and why?
Cloud9 CF template Integration
Issue #, if available
PR acceptance checklist
This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.
make version part=<major|minor|patch>?By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.