Add C9 template #215
Merged
Add C9 template #215
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mrinaudo-aws
requested changes
Apr 25, 2023
There was a problem hiding this comment.
Thank you, @rezabekf ! I have left comments and suggestions.
cjhar
reviewed
Apr 26, 2023
Co-authored-by: Matteo Rinaudo <52245107+mrinaudo-aws@users.noreply.github.com>
|
Thanks Chris and Matteo, i have applied all your suggestions and requested round two of the review. Cheers! |
cjhar
reviewed
Apr 26, 2023
Co-authored-by: Chris Harding <112917432+cjhar@users.noreply.github.com>
|
Hi @mrinaudo-aws, all the requested changes has been applied. Please review. |
mrinaudo-aws
previously approved these changes
Apr 27, 2023
There was a problem hiding this comment.
Hi @rezabekf ! Made minor suggestions - please review; otherwise LGTM.
Co-authored-by: Matteo Rinaudo <52245107+mrinaudo-aws@users.noreply.github.com>
Co-authored-by: Matteo Rinaudo <52245107+mrinaudo-aws@users.noreply.github.com>
Co-authored-by: Matteo Rinaudo <52245107+mrinaudo-aws@users.noreply.github.com>
Co-authored-by: Matteo Rinaudo <52245107+mrinaudo-aws@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do and why?
This PR revamps the Pre-requisities of the workshop as we are adding Cloud( as recommended way to do the labs.
Issue #, if available
PR acceptance checklist
This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.
make version part=<major|minor|patch>?By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.