Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

comment to correct level #214

Merged
merged 2 commits into from
May 22, 2023
Merged

Conversation

robert-hanuschke
Copy link
Contributor

What does this PR do and why?

the other templates have the comment for adding code indented to the correct level. here, the output section needs to be added which is a top level block, but the comment is indented by 2 spaces this leads to attendees indenting their code the same way, wrongly making Outputs a child of Resources

Issue #, if available

PR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

  • Added/Updated documentation if applicable.
  • Pre-commit checks passed.
  • Lint and Nag checks passed.
  • If releasing a new version, have you bumped the version make version part=<major|minor|patch>?

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

the other templates have the comment for adding code indented to the correct level.
here, the output section needs to be added which is a top level block, but the comment is indented by 2 spaces
this leads to attendees indenting their code the same way, wrongly making Outputs a child of Resources
@robert-hanuschke robert-hanuschke requested a review from a team as a code owner April 25, 2023 10:08
Copy link
Contributor

@rezabekf rezabekf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved. Thanks for the feedback!

@rezabekf rezabekf merged commit a4a1614 into aws-samples:main May 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants