-
Notifications
You must be signed in to change notification settings - Fork 63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rakefile for running tests with #6
Conversation
mentioned here as well https://blog.carbonfive.com/2013/06/28/sinatra-best-practices-part-two/ |
Once this is merged I can create a PR implementing Travis CI on this repo similar how I how it configured on my fork: https://travis-ci.org/equivalent/serverless-sinatra-sample So that this official repo can have a CI build badge similar to other Ruby projects: e.g. : https://github.com/equivalent/public_uid (badge in README.md) |
Thank you for all the PRs! |
Thank you guys for creating this repo example. Quite helpful. I've created blog post about it where I explain in details how it all works ;) https://blog.eq8.eu/article/sinatra-on-aws-lambda.html if you got any ideas pls let me know ;) |
Hi Tomas,
That's a great blog! Do you mind if I add the link of your blog post to the
README file?
By the way, I think it might be a little confusing for Lambda beginners
when they read 'That means if this Sinatra app needs to receive 1000
requests, it will spin up 1000 AWS Lambda Functions.' in the post. We both
know that if there are 1000 requests concurrently, AWS will try to run 1000
invocations for the same Lambda function. However, if it's 1000
requests/second, and each request only needs 200 ms to process, there could
only be 200 concurrent invocations at any point of time. (Reference:
https://docs.aws.amazon.com/lambda/latest/dg/scaling.html). If you can
clarify a bit, that would be great!
Anyways, we really appreciate your effort and contribution!
Best,
-Xiang Shen
…On Wed, Dec 12, 2018 at 12:46 AM Tomas Valent ***@***.***> wrote:
Thank you guys for creating this repo example. Quite helpful. I've created
blog post about it where I explain in details how it all works ;)
https://blog.eq8.eu/article/sinatra-on-aws-lambda.html
if you got any ideas pls let me know ;)
—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub
<#6 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AFgDU_JCnaXAqrG-_Y8CwmB6pFFAnzSXks5u4JhMgaJpZM4ZEOg7>
.
|
Hi Xiang,
yes sure, thank you for that
Yes definitely, I'll update it now. Thank you for pointing this out 🙏
The "Thank you" goes to you guys. In the past I was planing to do similar example project as soon as AWS announce official Ruby support. You guys beat me to it :) And really good job. It's great this example repo exist. Super helpful for Ruby community. It's already 31 reputation on https://www.reddit.com/r/ruby/comments/a5f7as/sinatra_on_aws_lambda/ in less than 24 hours |
Hi Tomas,
I have added your blog post link and also the 'we want FaaS' link to the
README file. I have also made changes so the Lambda function will work with
an ALB instead of only API GW. So if somebody doesn't want to define the
routes in API GW, they can use ALB which can use Cognito to authenticate as
well.
Thanks,
-Xiang
…On Wed, Dec 12, 2018 at 3:42 PM Tomas Valent ***@***.***> wrote:
Hi Xiang,
That's a great blog! Do you mind if I add the link of your blog post to
the README file?
yes sure, thank you for that
If you can clarify a bit, that would be great!
Yes definitely, I'll update it now. Thank you for pointing this out 🙏
Anyways, we really appreciate your effort and contribution!
The "Thank you" goes to you guys. In the past I was planing to do similar
example project as soon as AWS announce official Ruby support. You guys
beat me to it :) And really good job. It's great this example repo exist.
Super helpful for Ruby community. It's already 31 reputation on
https://www.reddit.com/r/ruby/comments/a5f7as/sinatra_on_aws_lambda/ in
less than 24 hours
—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub
<#6 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AFgDUwiIy8u6UXFOT-7qHvsdXxNshb3Gks5u4WpIgaJpZM4ZEOg7>
.
|
@xiangshen-dk oh nice 👍 I'll try the ALB implementatino next week Thank you for adding those links I've updated my article (several parts of it actually as I was writing it at 3AM in the morning), can you please have one more read if I got everything right 🙏 thank you |
Looks good to me. However, 'spin up' is not a phrase we would normally use
for Lambda. I saw your note in the blog though. I don't hate you but still
want to point that out. :)
Great job and really appreciate your work on this!
…On Wed, Dec 12, 2018 at 5:17 PM Tomas Valent ***@***.***> wrote:
@xiangshen-dk <https://github.com/xiangshen-dk> oh nice 👍 I'll try the
ALB implementatino next week
I've updated my article (several parts of it actually as I was writing it
at 3AM in the morning), can you please have one more read if I got
everything right 🙏 thank you
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#6 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AFgDU7EJfqKvsK3uNaK3ZcmcPL8wucjQks5u4YBogaJpZM4ZEOg7>
.
|
:D I was really trying to find a better phraze. Trough out the AWS Lambda docs I see the term "invocation" is used but honestly I don't think it captures the fact that "Lambda function is not present in the memory to receive call yet" and how "cold start" works not be clear enough for junior developers. is there a better term for this that you would recommend please ? |
@xiangshen-dk good news, article made it to Ruby Weekly (2nd place, that's in my opinion big deal) https://rubyweekly.com/issues/429 so there will be quite an exposure to the |
That's awesome!! Thanks for sharing!
Regarding your previous email, usually we just say AWS executes the Lambda
function. When a Lambda function is executed, it will go through different
stages. This blog post is a bit dated but it's still used when we talk
about Lambda function life cycle:
https://aws.amazon.com/blogs/compute/container-reuse-in-lambda/
Best,
-Xiang
…On Thu, Dec 13, 2018 at 1:42 PM Tomas Valent ***@***.***> wrote:
@xiangshen-dk <https://github.com/xiangshen-dk> good news, article made
it to Ruby Weekly (2nd place, that's in my opinion big deal)
https://rubyweekly.com/issues/429 so there will be quite an exposure to
the serverless-sinatra-sample repo in Ruby community 👍
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#6 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AFgDU85OGHuE_NQwyMQPt23FOQNHWMfSks5u4p98gaJpZM4ZEOg7>
.
|
Issue #, if available:
not applicable
Description of changes:
In Ruby world there is a good practice to configure default Rake task
rake
to run the tests. This is so that CI or anyone who clones the project run the task without knowing if it's RSpec or MiniTest testnig frameworkso in order to run tests all one need to do is run
rake
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.