New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rakefile for running tests with #6

Merged
merged 2 commits into from Dec 11, 2018

Conversation

Projects
None yet
2 participants
@equivalent
Copy link
Contributor

equivalent commented Dec 5, 2018

Issue #, if available:

not applicable

Description of changes:

In Ruby world there is a good practice to configure default Rake task rake to run the tests. This is so that CI or anyone who clones the project run the task without knowing if it's RSpec or MiniTest testnig framework

so in order to run tests all one need to do is run rake

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@equivalent

This comment has been minimized.

Copy link
Contributor

equivalent commented Dec 5, 2018

@equivalent

This comment has been minimized.

Copy link
Contributor

equivalent commented Dec 5, 2018

Once this is merged I can create a PR implementing Travis CI on this repo similar how I how it configured on my fork:

https://travis-ci.org/equivalent/serverless-sinatra-sample

So that this official repo can have a CI build badge similar to other Ruby projects:

screenshot from 2018-12-05 20-01-59

e.g. : https://github.com/equivalent/public_uid (badge in README.md)

@xiangshen-dk xiangshen-dk merged commit 84fd491 into aws-samples:master Dec 11, 2018

@xiangshen-dk

This comment has been minimized.

Copy link
Contributor

xiangshen-dk commented Dec 11, 2018

Thank you for all the PRs!

@equivalent

This comment has been minimized.

Copy link
Contributor

equivalent commented Dec 12, 2018

Thank you guys for creating this repo example. Quite helpful. I've created blog post about it where I explain in details how it all works ;) https://blog.eq8.eu/article/sinatra-on-aws-lambda.html

if you got any ideas pls let me know ;)

@xiangshen-dk

This comment has been minimized.

Copy link
Contributor

xiangshen-dk commented Dec 12, 2018

@equivalent

This comment has been minimized.

Copy link
Contributor

equivalent commented Dec 12, 2018

Hi Xiang,

That's a great blog! Do you mind if I add the link of your blog post to the README file?

yes sure, thank you for that

If you can clarify a bit, that would be great!

Yes definitely, I'll update it now. Thank you for pointing this out 🙏

Anyways, we really appreciate your effort and contribution!

The "Thank you" goes to you guys. In the past I was planing to do similar example project as soon as AWS announce official Ruby support. You guys beat me to it :) And really good job. It's great this example repo exist. Super helpful for Ruby community. It's already 31 reputation on https://www.reddit.com/r/ruby/comments/a5f7as/sinatra_on_aws_lambda/ in less than 24 hours

@xiangshen-dk

This comment has been minimized.

Copy link
Contributor

xiangshen-dk commented Dec 12, 2018

@equivalent

This comment has been minimized.

Copy link
Contributor

equivalent commented Dec 12, 2018

@xiangshen-dk oh nice 👍 I'll try the ALB implementatino next week

Thank you for adding those links

I've updated my article (several parts of it actually as I was writing it at 3AM in the morning), can you please have one more read if I got everything right 🙏 thank you

@xiangshen-dk

This comment has been minimized.

Copy link
Contributor

xiangshen-dk commented Dec 12, 2018

@equivalent

This comment has been minimized.

Copy link
Contributor

equivalent commented Dec 13, 2018

:D

I was really trying to find a better phraze. Trough out the AWS Lambda docs I see the term "invocation" is used but honestly I don't think it captures the fact that "Lambda function is not present in the memory to receive call yet" and how "cold start" works not be clear enough for junior developers.

is there a better term for this that you would recommend please ?

@equivalent

This comment has been minimized.

Copy link
Contributor

equivalent commented Dec 13, 2018

@xiangshen-dk good news, article made it to Ruby Weekly (2nd place, that's in my opinion big deal) https://rubyweekly.com/issues/429 so there will be quite an exposure to the serverless-sinatra-sample repo in Ruby community 👍

@xiangshen-dk

This comment has been minimized.

Copy link
Contributor

xiangshen-dk commented Dec 14, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment