Disable H264 send for iOS 15.1 #1801
Conversation
|
Change the title and commit from |
ltrung
changed the title
Updated. |
CHANGELOG.md
Outdated
| @@ -13,6 +13,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0 | |||
| ### Fixed | |||
|
|
|||
| - Fix priority downlink policy bandwidth estimation metrics to work with Safari. | |||
| - Add a workaround to switch to VP8 for iOS 15.1 due to Safari bug that causes crash with H.264 encoding. | |||
There was a problem hiding this comment.
Recommend adding a link to the WebKit ticket
| this.browser.name === 'ios-webview' || | ||
| (this.browser.name === 'safari' && | ||
| /( Mac )/i.test(navigator.userAgent) && | ||
| !!navigator.maxTouchPoints && |
There was a problem hiding this comment.
nit: This check is not needed as 0 > 1 or undefined > 1 will be false anyway.
src/task/SetLocalDescriptionTask.ts
Outdated
| @@ -1,6 +1,7 @@ | |||
| // Copyright Amazon.com, Inc. or its affiliates. All Rights Reserved. | |||
| // SPDX-License-Identifier: Apache-2.0 | |||
|
|
|||
| import { DefaultBrowserBehavior } from '..'; | |||
There was a problem hiding this comment.
Specify the path ../browserbehavior/DefaultBrowserBehavior in case we change how to export these files in index.ts?
| @@ -480,4 +480,76 @@ export default class DefaultSDP implements SDP { | |||
| } | |||
| return true; | |||
| } | |||
|
|
|||
| removeH264SupportFromSendSection(): DefaultSDP { | |||
There was a problem hiding this comment.
I feel guilty to ask this on whats mostly code i wrote :P, but can we sprinkle some high level comments in here. Its kinda a big blob of regex and string manipulation, which usually can be pretty fragile.
There was a problem hiding this comment.
I think more example SDP lines would be nice.
Co-authored-by: Henry Smith <hensmi@amazon.com>
Issue #1762:
iOS 15.1 devices could not enable video due to a Safari bug causes H.264 encoding to crash.
Description of changes:
Add a workaround to switch to VP8 for iOS 15.1 devices including iOS Safari (iPhone and iPad), iOS Chrome (iPhone and iPad), and iOS Firefox (iPhone).
Testing:
Can these tested using a demo application? Please provide reproducible step-by-step instructions.
Checklist:
Have you successfully run
npm run build:releaselocally? YesDo you add, modify, or delete public API definitions? If yes, has that been reviewed and approved? Yes
Do you change the wire protocol, e.g. the request method? If yes, has that been reviewed and approved? Yes
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.