Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix video issue for iOS 15.1 Webview in iPhone #1808

Merged
merged 2 commits into from Nov 19, 2021
Merged

Fix video issue for iOS 15.1 Webview in iPhone #1808

merged 2 commits into from Nov 19, 2021

Conversation

ltrung
Copy link
Contributor

@ltrung ltrung commented Nov 19, 2021

Description of changes:
Follow up for PR #1801 but adding check for iOS WebView.

Testing:
Tested in iOS WebView demo
Can these tested using a demo application? Please provide reproducible step-by-step instructions.

Join a meeting in iOS Safari (iPhone and iPad), iOS Chrome (iPhone and iPad), or iOS Firefox (iPhone).
Turn on the video in meeting
Verify that the video is on and the browser does not crash.

Checklist:

  1. Have you successfully run npm run build:release locally? Yes

  2. Do you add, modify, or delete public API definitions? If yes, has that been reviewed and approved? No

  3. Do you change the wire protocol, e.g. the request method? If yes, has that been reviewed and approved? No

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@ltrung ltrung requested a review from a team as a code owner November 19, 2021 00:40
@ltrung ltrung merged commit 8af993e into master Nov 19, 2021
@ltrung ltrung deleted the ios-15.1-fix branch November 19, 2021 01:10
dimitarz pushed a commit to dimitarz/amazon-chime-sdk-js that referenced this pull request Nov 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants