Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove support for serial docker pull image #1569

Merged
merged 1 commit into from
Sep 12, 2018
Merged

Conversation

sharanyad
Copy link
Contributor

@sharanyad sharanyad commented Sep 11, 2018

Summary

pre 1.9 docker versions supported only serial image pull. since we deprecated for docker versions < 1.9, we can remove support for serial pull and have concurrent image pull as default
see issue #1549 for details

Implementation details

Testing

  • Builds on Linux (make release)
  • Builds on Windows (go build -out amazon-ecs-agent.exe ./agent)
  • Unit tests on Linux (make test) pass
  • Unit tests on Windows (go test -timeout=25s ./agent/...) pass
  • Integration tests on Linux (make run-integ-tests) pass
  • Integration tests on Windows (.\scripts\run-integ-tests.ps1) pass
  • Functional tests on Linux (make run-functional-tests) pass
  • Functional tests on Windows (.\scripts\run-functional-tests.ps1) pass

New tests cover the changes: yes

Description for the changelog

NA

Licensing

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@sharanyad sharanyad requested review from yhlee-aws, adnxn and a team September 11, 2018 21:38
@sharanyad sharanyad added this to the 1.20.3 milestone Sep 11, 2018
@yhlee-aws
Copy link
Contributor

Did we not have any integ/functional test coverage on serial pull?

Copy link
Contributor

@yhlee-aws yhlee-aws left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please check that all tests pass

@sharanyad
Copy link
Contributor Author

Did we not have any integ/functional test coverage on serial pull?

We did have an integ test, which has been removed in this PR.
There are functional tests only for concurrent/parallel pull.

@sharanyad sharanyad merged commit 67ff85a into aws:dev Sep 12, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants