Rework KariusDx:config-cleanup-wait #302
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1. Rename config.CleanupWaitDuration to config.TaskCleanupWaitDuration to be more explicit about its intent. 2. Add a minimum threshold for the cleanup time. Accepting low values such as '1 us' causes the agent to deadlock. 3. Fix a bug in the engine code which could cause a deadlock when using en empty config.Config object in the engine. The waitEvent method will deadlock when waiting for cleanup if the cleanup go routine exits prematurely. A check has been added to the event duation to fix this. 4. Add functional tests for task cleanup.
…nvironment variable
1. Use the DefaultTaskCleanupWaitDuration while constructing default config. 2. Edit the debug message to fix inconsistent casing.
| taskCleanupWaitDuration := parseEnvVariableDuration("ECS_ENGINE_TASK_CLEANUP_WAIT_DURATION") | ||
| // If a value has been set for taskCleanupWaitDuration and the value is less than the minimum allowed cleanup duration, | ||
| // print a warning and override it | ||
| if taskCleanupWaitDuration < minimumTaskCleanupWaitDuration { |
There was a problem hiding this comment.
This logic should really be in NewConfig so it catches errors in FileConfig as well. Also, if you want to make FileConfig, EnvironmentConfig, and EC2MetadataConfig private as well, I wouldn't complain. 😄
There was a problem hiding this comment.
Ah, I fell into the trap. Will fix this.
Also made FileConfig, EnvironmentConfig, and EC2MetadataConfig private.
|
👍 |
|
merged |
This was referenced Feb 3, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addressed comments in #286. Also added functional tests and some validations.