add negative integration tests for gmsa on Linux #3752
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amogh09
reviewed
Jun 21, 2023
mrkdeng
force-pushed
the
gmsa-negative-tests
branch
from
de84c2e
to
759ffc1
Compare
mrkdeng
force-pushed
the
gmsa-negative-tests
branch
from
759ffc1
to
6ff2fce
Compare
amogh09
approved these changes
Jun 26, 2023
|
Approved with the understanding that a follow-up PR will be created to add descriptions above the new test functions. |
mythri-garaga
approved these changes
Jun 27, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR is to add negative integration tests for gMSA on Linux, which covers three cases:
Implementation details
Add integration tests to
agent/engine/engine_sudo_linux_integ_test.goTesting
New tests cover the changes:
YES
Description for the changelog
Licensing
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.