Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add negative integration tests for gmsa on Linux #3707

Closed
wants to merge 3 commits into from

Conversation

mrkdeng
Copy link
Contributor

@mrkdeng mrkdeng commented May 21, 2023

Summary

This PR is to add negative integration tests for gMSA on Linux, which covers three cases:

  1. gMSA credentialspec file can't be found in S3 bucket
  2. gMSA credentialspec file can't be found in SSM documents
  3. gMSA Deamon is not running

Implementation details

Add integration tests to agent/engine/engine_sudo_linux_integ_test.go

Testing

New tests cover the changes:
YES

Description for the changelog

Licensing

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@mrkdeng mrkdeng force-pushed the gmsa-negative-integ-tests branch from 3a1bc13 to 8ea7b5d Compare May 22, 2023 00:15
@mrkdeng mrkdeng marked this pull request as ready for review May 22, 2023 00:40
@mrkdeng mrkdeng requested a review from a team as a code owner May 22, 2023 00:40
@mrkdeng mrkdeng marked this pull request as draft May 22, 2023 00:46
@saikiranakula-amzn saikiranakula-amzn marked this pull request as ready for review June 15, 2023 16:00
@mrkdeng mrkdeng closed this Jun 19, 2023
@mrkdeng mrkdeng reopened this Jun 19, 2023
@mrkdeng mrkdeng closed this Jun 19, 2023
@mrkdeng mrkdeng deleted the gmsa-negative-integ-tests branch June 19, 2023 17:59
@mrkdeng
Copy link
Contributor Author

mrkdeng commented Jun 20, 2023

I have to close this PR and raise a new one #3752. I messed up with my local repo and tried rebase a few times but it wouldn't come to a clean commit history. Since the code changes are relatively small. I create a new branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants