add negative integration tests for gmsa on Linux #3707
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mrkdeng
force-pushed
the
gmsa-negative-integ-tests
branch
from
3a1bc13
to
8ea7b5d
Compare
…g/amazon-ecs-agent into gmsa-negative-integ-tests
|
I have to close this PR and raise a new one #3752. I messed up with my local repo and tried rebase a few times but it wouldn't come to a clean commit history. Since the code changes are relatively small. I create a new branch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR is to add negative integration tests for gMSA on Linux, which covers three cases:
Implementation details
Add integration tests to
agent/engine/engine_sudo_linux_integ_test.goTesting
New tests cover the changes:
YES
Description for the changelog
Licensing
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.