Windows daemon manager #4239
Merged
Windows daemon manager #4239
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
saurabhc123
force-pushed
the
windowsDaemonManager
branch
5 times, most recently
from
d7ea047
to
6661a29
Compare
mye956
force-pushed
the
feature/ebs-windows
branch
2 times, most recently
from
4179cea
to
225bb4b
Compare
saurabhc123
force-pushed
the
windowsDaemonManager
branch
3 times, most recently
from
0046c02
to
67b17ce
Compare
saurabhc123
commented
Jul 12, 2024
mye956
reviewed
Jul 14, 2024
mye956
reviewed
Jul 14, 2024
mye956
reviewed
Jul 14, 2024
mye956
reviewed
Jul 14, 2024
mye956
reviewed
Jul 14, 2024
mye956
reviewed
Jul 14, 2024
| defaultECSAgentLogPathContainer = "/log" | ||
| socketPathHostRoot = "/var/run/ecs" | ||
| logPathHostRoot = "/log/daemons" | ||
| daemonUID = 0 |
There was a problem hiding this comment.
nit (non-blocking): I'm seeing a lot of different config files that's scattered in different files. Perhaps we can try to scope it down a bit to having fewer config files.
There was a problem hiding this comment.
I have refactored as much as possible. For some constants that are specific to a module, I have kept it to the module itself. Most are limited to the module. For the Linux ones, I refactored as much as possible, but didn't want to perturb the code too much. Let me know if you see any config that can be made global.
jiuchoe4
force-pushed
the
windowsDaemonManager
branch
3 times, most recently
from
82fc629
to
64718fc
Compare
jiuchoe4
force-pushed
the
windowsDaemonManager
branch
from
64718fc
to
70e9fa1
Compare
mye956
previously approved these changes
Jul 17, 2024
saurabhc123
force-pushed
the
windowsDaemonManager
branch
from
67b17ce
to
864edbe
Compare
jiuchoe4
force-pushed
the
windowsDaemonManager
branch
from
864edbe
to
70e9fa1
Compare
saurabhc123
force-pushed
the
windowsDaemonManager
branch
from
8df1c99
to
320e62a
Compare
saurabhc123
force-pushed
the
windowsDaemonManager
branch
from
320e62a
to
a421e01
Compare
mye956
approved these changes
Jul 23, 2024
xxx0624
reviewed
Jul 23, 2024
xxx0624
approved these changes
Jul 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds the
DaemonManagerandManagedDaemoncomponents to support EBS-TaskAttach for Windows.Implementation details
We refactored the existing
DaemonManagerandManagedDaemonmodules for linux and repurposed the high-level workflow. The platform specific details were moved to the respective windows/linux modules.Testing
We used the existing linux tests and refactored them so that all of them can be repurposed for Windows.
New tests cover the changes:
YesDescription for the changelog
Add support EBS-TaskAttach for Windows.
Licensing
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.