Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v1.13.0 release #543

Merged
merged 15 commits into from
Oct 4, 2016
Merged

v1.13.0 release #543

merged 15 commits into from
Oct 4, 2016

Conversation

nmeyerhans
Copy link
Contributor

  • Feature - Implemented automated image cleanup
  • Enhancement - Add credential caching for ECR
  • Enhancement - Add support for security-opt=no-new-privileges

r? @aaithal @samuelkarp

David Bell and others added 14 commits September 7, 2016 16:11
This avoids having to get fetch new authorization tokens on each ECR image pull by adding an LRU expiring cache for each ECR Client. This also adds a new client wrapper for ECR client vs. using the SDK directly. This also brings in a new dependency on testify for assert & suite.
- Support for Docker version 1.23
Adds support for security-opts=no-new-privileges
Adding Mock ImageManager and corresponding changes

Refactoring changes and adding InspectImage method in DockerClient interface

Adding unit tests for Accounting Images in ImageManager

Handling Image name with multiple Image IDs and image manager tests

Retrieving Images for cleanup

Handling Image name with multiple Image IDs and image manager tests

Remove existing image name with different ImageId

Periodic Image Cleanup

Added unit tests for periodic image removal

Using context.WithTimeout instead of timer for RemoveImage

Fine grained locking in Image Manager

saving image manager states

Locking for pull and delete image operations and merge changes

Image State Manager changes and fixing tests

Image Manager unit tests

Image State failed to be removed not chosen for deletion again
Add fields to ImageManager to allow for overriding of defaults

Adding Integ tests and target for ImageCleanup
@@ -1,5 +1,10 @@
# Changelog

## 1.13.0
* Feature - Implemented automated image cleanup
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you end the sentences with a period?

* Feature - Implemented automated image cleanup
* Enhancement - Add credential caching for ECR
* Enhancement - Add support for security-opt=no-new-privileges

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add "Bug - Fixed a potential deadlock in dockerstate." (from this commit)?

Copy link
Contributor

@samuelkarp samuelkarp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Copy link
Contributor

@aaithal aaithal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@nmeyerhans nmeyerhans merged commit aebcbca into aws:master Oct 4, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants