Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update AL2022 Neuron Volume Type to GP3 and change AMI description #77

Merged
merged 1 commit into from Sep 6, 2022

Conversation

Realmonia
Copy link
Contributor

@Realmonia Realmonia commented Sep 6, 2022

Summary

Update Volume type for al2022 neuron

Implementation details

Testing

There are multiple test build of AL2022 Neuron ECS Optimized AMI and tested with MACIS - #58. For this specific PR, I built an ECS Optimized AMI in my account - ami-0ca1eaea9f1053bc9

I haven't done the full test, because there is a problem with ec2 that neuron devices are not able to be created. (This is specific to distribution release AFAIK). I will do the full test before merging feature branch to main.

New tests cover the changes: No

Description for the changelog

Licensing

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@fierlion
Copy link
Member

fierlion commented Sep 6, 2022

How was this tested? Is there a recent commit that already tested this change

@Realmonia
Copy link
Contributor Author

How was this tested? Is there a recent commit that already tested this change

There are multiple test build of AL2022 Neuron ECS Optimized AMI and tested with MACIS - #58. For this specific PR, I built an ECS Optimized AMI in my account - ami-0ca1eaea9f1053bc9

I haven't done the full test, because there is a problem with ec2 that neuron devices are not able to be created. (This is specific to distribution release AFAIK). I will do the full test before merging feature branch to main.

@Realmonia Realmonia merged commit 5d3a071 into aws:feature/al2022neuron Sep 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants