Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use filepath.Join for default ECS local I/O files #796

Closed
efekarakus opened this issue Jun 18, 2019 · 0 comments
Closed

Use filepath.Join for default ECS local I/O files #796

efekarakus opened this issue Jun 18, 2019 · 0 comments
Assignees
Labels
Debt Fixes to improve our readability of our codebase ecs-local Issues related to the "local" subcommand.
Projects

Comments

@efekarakus
Copy link
Contributor

The paths of the default task-definition.json and docker-compose.local.yml files are referenced with ./. We would like to use filepath.Join or equivalent.

See for full thread: #785 (comment)

@efekarakus efekarakus created this issue from a note in ECS Local (To do) Jun 18, 2019
@efekarakus efekarakus added Task Debt Fixes to improve our readability of our codebase labels Jun 18, 2019
iamhopaul123 added a commit to iamhopaul123/amazon-ecs-cli that referenced this issue Jun 19, 2019
iamhopaul123 added a commit to iamhopaul123/amazon-ecs-cli that referenced this issue Jun 19, 2019
@iamhopaul123 iamhopaul123 self-assigned this Jun 19, 2019
@iamhopaul123 iamhopaul123 moved this from To do to In progress in ECS Local Jun 19, 2019
iamhopaul123 added a commit that referenced this issue Jun 19, 2019
@iamhopaul123 iamhopaul123 moved this from In progress to Done in ECS Local Jun 19, 2019
@efekarakus efekarakus added the ecs-local Issues related to the "local" subcommand. label Jun 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Debt Fixes to improve our readability of our codebase ecs-local Issues related to the "local" subcommand.
Projects
ECS Local
  
Done
Development

No branches or pull requests

2 participants